HomePhabricator
Diffusion Comm d0a756e73375

[web] Display videos correctly in `Multimedia` component

Tags
None
Referenced Files
F265264: 3e73f7.png
Nov 29 2022, 2:14 PM
File Not Attached
F265263: 8edddc.png
Nov 29 2022, 2:14 PM
File Not Attached
Subscribers
None

Description

[web] Display videos correctly in Multimedia component

Summary:
Context: https://linear.app/comm/issue/ENG-1512/render-video-messages-inline-on-web

Basically display media with <video> tag instead of <img> tag if mediaType === "video". Also remove any onClick functionality since we don't have any sort of full-screen video playback experience on web.

Test Plan:
Here's how it looks in Safari:

8edddc.png (1×1 px, 2 MB)

Here's how it looks in Chrome:

3e73f7.png (1×1 px, 2 MB)

Made sure that images continue to look as expected.

Reviewers: tomek, ginsu, rohan, ashoat

Reviewed By: ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5759

Details

Provenance
atulAuthored on Nov 29 2022, 1:10 PM
Reviewer
ashoat
Differential Revision
D5759: [web] Display videos correctly in `Multimedia` component
Parents
rCOMM8ebcaf431419: Revert "Temporary changes for staff release"
Branches
Unknown
Tags
Unknown