HomePhabricator
Diffusion Comm d0cd85eac1d5

[lib] Render EntityText directly from notifRobotextForMessageInfo

Description

[lib] Render EntityText directly from notifRobotextForMessageInfo

Summary:
This diff does three things:

  1. Renames strippedRobotextForMessageInfo to notifRobotextForMessageInfo to better reflect its intended use
  2. Modifies it to return an EntityText directly instead of using entityTextToRawString, which isn't capable of resolving ENS names
  3. Stops passing notifRobotextForMessageInfo from notif-utils into the message specs, and instead just import it from the message specs. Note that this introduces a require cycle, but I think this is fine in modern Node.js (where this code is getting executed)

Depends on D6574

Test Plan: Tested in combination with later notif diffs

Reviewers: atul, ginsu, michal, marcin

Reviewed By: atul

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D6575

Details

Provenance
ashoatAuthored on Feb 3 2023, 6:53 PM
Reviewer
atul
Differential Revision
D6575: [lib] Render EntityText directly from notifRobotextForMessageInfo
Parents
rCOMM8db70b4db443: [lib][keyserver] Allow notificationTexts to render EntityText
Branches
Unknown
Tags
Unknown