Paths

Table of Contentst

[lib][keyserver] Allow notificationTexts to render EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 5:59 PM.

Details

Reviewers

atul
ginsu
michal
marcin

Commits

rCOMM8db70b4db443: [lib][keyserver] Allow notificationTexts to render EntityText

Summary

This diff adds support to keyserver for resolving EntityText returned by a message spec's notificationTexts function.

Depends on D6573

Test Plan

Tested in combination with later notif diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 5:59 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 5:59 PM

ashoat added a child revision: D6575: [lib] Render EntityText directly from notifRobotextForMessageInfo.Feb 4 2023, 6:01 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2023, 6:01 PM

Harbormaster failed remote builds in B16088: Diff 21975!

Revert minor change to types

Harbormaster completed remote builds in B16101: Diff 21993.Feb 4 2023, 8:16 PM

ashoat requested review of this revision.Feb 4 2023, 8:16 PM

atul accepted this revision.Feb 4 2023, 9:37 PM

This revision is now accepted and ready to land.Feb 4 2023, 9:37 PM

Closed by commit rCOMM8db70b4db443: [lib][keyserver] Allow notificationTexts to render EntityText. · Explain WhyFeb 5 2023, 3:53 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8db70b4db443: [lib][keyserver] Allow notificationTexts to render EntityText.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

3 lines

lib/

shared/

notif-utils.js

70 lines

types/

notif-types.js

9 lines

Diff 22053

View Options

keyserver/src/push/send.js

View Options

lib/shared/notif-utils.js

View Options

[lib][keyserver] Allow notificationTexts to render EntityTextClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22053

keyserver/src/push/send.js

lib/shared/notif-utils.js

lib/types/notif-types.js

[lib][keyserver] Allow notificationTexts to render EntityText
ClosedPublic
Actions

Revision Contents
Changeset List