Paths

Table of Contentst

[lib] Migrate Reaction notifText to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 3:49 PM

	Unknown Object (File)
	Oct 12 2024, 5:08 PM

	Unknown Object (File)
	Oct 10 2024, 1:53 PM

	Unknown Object (File)
	Sep 30 2024, 4:30 AM

	Unknown Object (File)
	Sep 30 2024, 2:37 AM

View All 66 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMMf5d6b25d1823: [lib] Migrate Reaction notifText to use EntityText

Summary

Depends on D6582

Test Plan

Generated Reaction message on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 10:05 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:05 AM

ashoat added a child revision: D6584: [lib] Migrate Multimedia notifText to use EntityText.Feb 4 2023, 10:06 AM

Harbormaster completed remote builds in B16097: Diff 21989.Feb 4 2023, 10:23 AM

ashoat requested review of this revision.Feb 4 2023, 10:23 AM

atul accepted this revision.Feb 4 2023, 12:09 PM

This revision is now accepted and ready to land.Feb 4 2023, 12:09 PM

Closed by commit rCOMMf5d6b25d1823: [lib] Migrate Reaction notifText to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf5d6b25d1823: [lib] Migrate Reaction notifText to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

reaction-message-spec.js

17 lines

Diff 22064

View Options

lib/shared/messages/reaction-message-spec.js

[lib] Migrate Reaction notifText to use EntityTextClosedPublicActions