[lib] Stop passing notifThreadName to notificationTexts
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:06 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 29, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 3:52 PM

	Unknown Object (File)
	Tue, Oct 29, 3:49 PM

	Unknown Object (File)
	Sep 30 2024, 1:29 AM

	Unknown Object (File)
	Sep 30 2024, 1:17 AM

	Unknown Object (File)
	Sep 29 2024, 11:10 PM

View All 79 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMM738aa93507fc: [lib] Stop passing notifThreadName to notificationTexts

Summary

This is no longer necessary, as the same functionality is handled through the EntityText framework.

Depends on D6584

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 10:06 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:06 AM

Harbormaster completed remote builds in B16099: Diff 21991.Feb 4 2023, 10:27 AM

ashoat requested review of this revision.Feb 4 2023, 10:27 AM

atul accepted this revision.Feb 4 2023, 12:10 PM

This revision is now accepted and ready to land.Feb 4 2023, 12:10 PM

Delete notifThreadName as it's no longer used

This revision was landed with ongoing or failed builds.Feb 5 2023, 8:01 AM

Closed by commit rCOMM738aa93507fc: [lib] Stop passing notifThreadName to notificationTexts (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM738aa93507fc: [lib] Stop passing notifThreadName to notificationTexts.

Harbormaster completed remote builds in B16146: Diff 22055.Feb 5 2023, 8:12 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

message-spec.js

1 line

notif-utils.js

13 lines

Diff 22066

View Options

lib/shared/messages/message-spec.js