[lib] Migrate CreateSidebar notifText to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:04 AM.

Details

Reviewers

atul

Commits

rCOMMb853350fe06d: [lib] Migrate CreateSidebar notifText to use EntityText

Summary

Depends on D6578

Test Plan

Generated CreateSidebar message on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 10:04 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:04 AM

ashoat added a child revision: D6580: [lib] Migrate JoinThread/LeaveThread notifTexts to use EntityText.Feb 4 2023, 10:04 AM

Harbormaster completed remote builds in B16093: Diff 21985.Feb 4 2023, 12:18 PM

ashoat requested review of this revision.Feb 4 2023, 12:18 PM

atul accepted this revision.Feb 4 2023, 2:23 PM

This revision is now accepted and ready to land.Feb 4 2023, 2:23 PM

Closed by commit rCOMMb853350fe06d: [lib] Migrate CreateSidebar notifText to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb853350fe06d: [lib] Migrate CreateSidebar notifText to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

create-sidebar-message-spec.js

31 lines

Diff 22060

View Options

lib/shared/messages/create-sidebar-message-spec.js

[lib] Migrate CreateSidebar notifText to use EntityTextClosedPublicActions