HomePhabricator
Diffusion Comm d9602e7aa877

[native] [web] Improve wording when clearing thread name or description

Tags
None
Referenced Files
F82065: Screen Shot 2022-06-23 at 1.03.44 PM.png
Jun 28 2022, 1:54 PM
File Not Attached
F82063: Screen Shot 2022-06-23 at 1.03.27 PM.png
Jun 28 2022, 1:54 PM
File Not Attached
F82062: Screen Shot 2022-06-22 at 4.41.58 PM.png
Jun 28 2022, 1:54 PM
File Not Attached
F82064: Screen Shot 2022-06-22 at 4.45.54 PM.png
Jun 28 2022, 1:54 PM
File Not Attached
F82080: image.png
Jun 28 2022, 1:54 PM
File Not Attached
F82079: image.png
Jun 28 2022, 1:54 PM
File Not Attached
F82058: image.png
Jun 28 2022, 1:54 PM
File Not Attached
F82057: image.png
Jun 28 2022, 1:54 PM
File Not Attached
Subscribers

Description

[native] [web] Improve wording when clearing thread name or description

Summary:
Related Linear issue with full context here. Improved the wording of the robotext that is outputted when setting the thread name or description to the empty string.

Before:

image.png (406×1 px, 110 KB)

After:

image.png (502×964 px, 50 KB)

Test Plan:
Looks as expected on web and native, also changed thread name and description on web and native and both platforms match/work as expected:

image.png (808×814 px, 115 KB)
image.png (736×952 px, 77 KB)

Also tested to make sure the notification text matches the updated robotext (thanks @palys-swm for your help here!):

Screen Shot 2022-06-22 at 4.45.54 PM.png (2×1 px, 2 MB)
Screen Shot 2022-06-22 at 4.41.58 PM.png (2×1 px, 2 MB)
Screen Shot 2022-06-23 at 1.03.27 PM.png (2×1 px, 2 MB)
Screen Shot 2022-06-23 at 1.03.44 PM.png (2×1 px, 2 MB)

Reviewers: atul, palys-swm, ashoat

Reviewed By: atul, palys-swm, ashoat

Subscribers: ashoat, Adrian, palys-swm

Differential Revision: https://phab.comm.dev/D4346

Details

Provenance
aboshAuthored on Jun 23 2022, 11:11 AM
Reviewer
atul
Differential Revision
D4346: [native] [web] Improve wording when clearing thread name or description
Parents
rCOMMb656afcf2e70: [web] Fix sidebar title cutoff in `ChatThreadList`
Branches
Unknown
Tags
Unknown