HomePhabricator
Diffusion Comm db5bb3332bce

[desktop] Enable unused-promise=error Flow lint

Description

[desktop] Enable unused-promise=error Flow lint

Summary:
Following up on what I said in D10184:

Once I get an answer there, I'll decide on how to proceed for desktop, and submit some follow-up diffs to enable unused-promise for it as well.

I received a partial answer, and did some follow-up research myself. It looks like we can treat desktop like native and web, since it doesn't crash on unhandled promise rejections, unlike keyserver.

As such, this diff mostly prefix invocations with void, with one exception where I add an await instead in an async IIFE where the result is thrown away anyways.

Test Plan: Flow

Reviewers: michal, marcin

Reviewed By: michal

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D10199

Details

Provenance
ashoatAuthored on Dec 5 2023, 7:53 PM
Reviewer
michal
Differential Revision
D10199: [desktop] Enable unused-promise=error Flow lint
Parents
rCOMM1e2ad555d80c: [electron-update-server] Specify platform in docker compose
Branches
Unknown
Tags
Unknown