Page MenuHomePhabricator

[desktop] Enable unused-promise=error Flow lint
ClosedPublic

Authored by ashoat on Dec 5 2023, 7:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 12:41 PM
Unknown Object (File)
Fri, Nov 8, 11:11 AM
Unknown Object (File)
Fri, Nov 8, 11:00 AM
Unknown Object (File)
Fri, Nov 8, 12:10 AM
Unknown Object (File)
Thu, Nov 7, 11:36 PM
Unknown Object (File)
Thu, Nov 7, 11:22 PM
Unknown Object (File)
Thu, Nov 7, 5:36 AM
Unknown Object (File)
Oct 16 2024, 2:35 AM
Subscribers

Details

Summary

Following up on what I said in D10184:

Once I get an answer there, I'll decide on how to proceed for desktop, and submit some follow-up diffs to enable unused-promise for it as well.

I received a partial answer, and did some follow-up research myself. It looks like we can treat desktop like native and web, since it doesn't crash on unhandled promise rejections, unlike keyserver.

As such, this diff mostly prefix invocations with void, with one exception where I add an await instead in an async IIFE where the result is thrown away anyways.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable