HomePhabricator
Diffusion Comm dc735eeee8c0

[web] fix reaction tooltip not showing the correct number of users

Description

[web] fix reaction tooltip not showing the correct number of users

Summary:
When a message has more than 5 reactions, the reaction tooltip should only be showing the first 5 usernames then a "See more" text. However, this was not the case and we were showing all the usernames which resulted in the following visual bug.

Screenshot 2024-02-09 at 11.26.27 AM.png (458×306 px, 35 KB)

This diff fixes this issue

Linear task: https://linear.app/comm/issue/ENG-6328/show-more-in-reaction-tooltip-is-not-working-as-expected

Test Plan:
Please see the screenshots below

before:

Screenshot 2024-02-09 at 11.28.50 AM.png (582×480 px, 44 KB)

after:

Screenshot 2024-02-09 at 11.28.05 AM.png (512×314 px, 27 KB)

confirmed tooltip still looks good with < 5 reactions

Screenshot 2024-02-09 at 11.27.50 AM.png (416×300 px, 16 KB)

Reviewers: atul, inka

Reviewed By: atul

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D11014

Details

Provenance
ginsuAuthored on Feb 9 2024, 8:21 AM
Reviewer
atul
Differential Revision
D11014: [web] fix reaction tooltip not showing the correct number of users
Parents
rCOMMb01e5441ce0d: [lib] Include `specialRole` field in `RoleInfo` for future clients
Branches
Unknown
Tags
Unknown