HomePhabricator
Diffusion Comm e0f8b65e0b18

[native] Memoize construction of `sidebars` in `ChatThreadListItem`

Tags
None
Referenced Files
F746694: 8cb34d.png
Sep 8 2023, 3:05 PM
File Not Attached
F746693: 014d54.png
Sep 8 2023, 3:05 PM
File Not Attached
Subscribers
None

Description

[native] Memoize construction of sidebars in ChatThreadListItem

Summary:
This was getting re-rendered every time which recursively led to ChatThreadListSidebar, etc getting re-rendered every time. This change means ChatThreadListSidebar will render only once (unless something relevant changes).

Before:

014d54.png (1×2 px, 648 KB)

After:

8cb34d.png (1×2 px, 892 KB)


Depends on D9100

Test Plan: Things continue to work as expected.

Reviewers: ginsu, rohan, tomek

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D9102

Details

Provenance
atulAuthored on Sep 8 2023, 3:01 PM
Reviewer
tomek
Differential Revision
D9102: [native] Memoize construction of `sidebars` in `ChatThreadListItem`
Parents
rCOMM1c5e50b949b6: [native] Memoize `SwipeableThread`
Branches
Unknown
Tags
Unknown