[native] Memoize `SwipeableThread`
ClosedPublic
Actions

Authored by atul on Sep 7 2023, 10:05 AM.

Details

Reviewers

ginsu
rohan
tomek

Commits

rCOMM1c5e50b949b6: [native] Memoize `SwipeableThread`

Summary

The real performance gains will come from adding memoization to ChatThreadListItem and ChatThreadListSidebar, but this is a prerequisite for those optimizations to make a difference.

Depends on D9099

Test Plan

Continue to look and behave as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Sep 7 2023, 10:05 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 7 2023, 10:05 AM

Harbormaster completed remote builds in B22432: Diff 30848.Sep 7 2023, 10:23 AM

atul requested review of this revision.Sep 7 2023, 10:23 AM

atul added a child revision: D9102: [native] Memoize construction of `sidebars` in `ChatThreadListItem`.Sep 7 2023, 10:51 AM

tomek accepted this revision.Sep 8 2023, 2:22 AM

tomek added inline comments.

native/chat/swipeable-thread.react.js
82–93 ↗	(On Diff #30848)	Creating a memo that depends on children doesn't always work. The problem appears when `SwipeableThread` has more than one child <SwipeableThread> <View .../> </SwipeableThread> vs <SwipeableThread> <View .../> <View .../> </SwipeableThread> In the second case, `props.children` is an array that is created on every render, which means that this memo will be recomputed every time. Not sure if it can be fixed from this component, but we can check the usages of `SwipeableThread`.