HomePhabricator
Diffusion Comm e37c0d6f5d79

[desktop] Handle autoUpdate errors

Description

[desktop] Handle autoUpdate errors

Summary:
We want to handle autoUpdate errors (in particular error about no network connection). If we add a listener to an error event electron no longer displays the native alert with the error. Now we can just log it and restart the update schedule.

This replaces D6683 and D6684 as it's a much better solution.

Test Plan: Run the app, turn of internet connection. Check if the error is displayed and the app continues to check for updates.

Reviewers: tomek, kamil

Reviewed By: kamil

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D7032

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Mar 10 2023, 8:21 AM
Reviewer
kamil
Differential Revision
D7032: [desktop] Handle autoUpdate errors
Parents
rCOMMabde466ef6fe: [web] Use notifPermissionAlertInfo
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMMe37c0d6f5d79: [desktop] Handle autoUpdate errors (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Mar 16 2023, 7:46 AM