Page MenuHomePhabricator

[desktop] Ignore exceptions about being offline
AbandonedPublic

Authored by michal on Feb 10 2023, 2:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 1:13 AM
Unknown Object (File)
Fri, Apr 12, 1:12 AM
Unknown Object (File)
Fri, Apr 12, 1:12 AM
Unknown Object (File)
Fri, Apr 12, 1:12 AM
Unknown Object (File)
Fri, Apr 12, 1:08 AM
Unknown Object (File)
Tue, Apr 2, 12:35 PM
Unknown Object (File)
Wed, Mar 20, 9:17 PM
Unknown Object (File)
Wed, Mar 20, 9:17 PM
Subscribers

Details

Summary

ENG-2923
If we call autoUpdater.checkForUpdates() while we are offline there will be an exception thrown. Unfortunately we can't just try{}catch{} but we can catch all exceptions and swallow all exceptions with a message about being offline. We already notify the user about being offline with the DISCONNECTED bar. If it's some other exceptions we can call dialog.showErrorBox to get the previous behaviour.

Test Plan

Check if autoUpdater.checkForUpdates() is ignored correctly. Check if other exceptions are displayed correctly.

Diff Detail

Repository
rCOMM Comm
Branch
eng2923
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat added inline comments.
desktop/src/main.js
296 ↗(On Diff #22399)

Can we keep the same text as before?

This revision is now accepted and ready to land.Feb 13 2023, 2:59 PM