HomePhabricator
Diffusion Comm eb1b4bf0c1e6

[native][web] Trigger sendCallbacks on retries

Description

[native][web] Trigger sendCallbacks on retries

Summary:
This is part 3 of my comment on D7388:

Part of the issue is that sendCallbacks would not be triggered from a retry. So if a user searched for a thread with an already-existing local pending message (that failed to send), the retry of the failed message would not clear the "search". This problem exists for native as well, and is addressed in yet another diff later in the stack.

Depends on D7407

Test Plan:
On both native and web, I performed the following steps:

  1. Start trying to create a chat that does not exist. On native, it needs to be with two friends of the test user (otherwise the search experience closes when you select a non-friend, and you already have a chat with all current friends)
  2. Kill your local keyserver and then try creating the chat by sending a media or text message (try both)
  3. It should fail. Now go back, and bring up the same "pending chat" by repeating the steps in 1
  4. Hit the "RETRY?" button and make sure the "search" experience goes away

Reviewers: tomek, inka

Reviewed By: tomek

Subscribers: atul

Differential Revision: https://phab.comm.dev/D7408

Details

Provenance
ashoatAuthored on Apr 12 2023, 6:21 PM
Reviewer
tomek
Differential Revision
D7408: [native][web] Trigger sendCallbacks on retries
Parents
rCOMM3a0cacc24d1d: [web] Trigger sendCallbacks on multimedia messages
Branches
Unknown
Tags
Unknown