Page MenuHomePhabricator

[native][web] Trigger sendCallbacks on retries
ClosedPublic

Authored by ashoat on Apr 12 2023, 6:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 2:40 AM
Unknown Object (File)
Thu, Dec 5, 1:28 AM
Unknown Object (File)
Nov 5 2024, 4:17 AM
Unknown Object (File)
Nov 5 2024, 4:17 AM
Unknown Object (File)
Nov 1 2024, 8:33 AM
Unknown Object (File)
Nov 1 2024, 8:33 AM
Unknown Object (File)
Nov 1 2024, 8:33 AM
Unknown Object (File)
Nov 1 2024, 8:31 AM
Subscribers

Details

Summary

This is part 3 of my comment on D7388:

Part of the issue is that sendCallbacks would not be triggered from a retry. So if a user searched for a thread with an already-existing local pending message (that failed to send), the retry of the failed message would not clear the "search". This problem exists for native as well, and is addressed in yet another diff later in the stack.

Depends on D7407

Test Plan

On both native and web, I performed the following steps:

  1. Start trying to create a chat that does not exist. On native, it needs to be with two friends of the test user (otherwise the search experience closes when you select a non-friend, and you already have a chat with all current friends)
  2. Kill your local keyserver and then try creating the chat by sending a media or text message (try both)
  3. It should fail. Now go back, and bring up the same "pending chat" by repeating the steps in 1
  4. Hit the "RETRY?" button and make sure the "search" experience goes away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable