HomePhabricator
Diffusion Comm eeba9b9d02ac

[native] Fix issue creating Calendar event on Android

Description

[native] Fix issue creating Calendar event on Android

Summary:
We've had a long-standing issue with calendar event creation on Android: ENG-24

While testing the calendar on Android, I noticed that the background behind ThreadPickerModal wasn't showing. I found this relevant option in the React Navigation docs, which cautioned to instead use presentation: 'transparentModal' if you have a transparent modal.

ThreadPickerModal and its many siblings are indeed transparent modals, so using presentation: 'transparentModal' fixed the issue where the screen behind the modal wasn't showing. Turns out this also solved the bug in calendar event creation, which was happening because the previous screen was unmounted and the complex chain of events that normally handles dismissing the ThreadPickerModal after the new Entry's TextInput is focused was malfunctioning as a result.

Test Plan: Confirm it's possible to creation a calendar event on Android without the TextInput immediately dismissing and the new Entry being auto-deleted as a result

Reviewers: inka, tomek

Reviewed By: tomek

Subscribers: atul

Differential Revision: https://phab.comm.dev/D5891

Details

Provenance
ashoatAuthored on Dec 17 2022, 6:50 PM
Reviewer
tomek
Differential Revision
D5891: [native] Fix issue creating Calendar event on Android
Parents
rCOMM53ee9bc3a080: [lib] Handle string exception in getMessageForException
Branches
Unknown
Tags
Unknown