Page MenuHomePhabricator

[native] Fix issue creating Calendar event on Android
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 9 2024, 2:31 AM
Unknown Object (File)
Nov 9 2024, 2:30 AM
Unknown Object (File)
Nov 9 2024, 2:28 AM
Unknown Object (File)
Nov 9 2024, 1:19 AM
Unknown Object (File)
Nov 8 2024, 3:07 AM
Unknown Object (File)
Nov 6 2024, 7:10 PM
Unknown Object (File)
Nov 6 2024, 6:24 AM
Unknown Object (File)
Nov 4 2024, 8:23 AM
Subscribers

Details

Summary

We've had a long-standing issue with calendar event creation on Android: ENG-24

While testing the calendar on Android, I noticed that the background behind ThreadPickerModal wasn't showing. I found this relevant option in the React Navigation docs, which cautioned to instead use presentation: 'transparentModal' if you have a transparent modal.

ThreadPickerModal and its many siblings are indeed transparent modals, so using presentation: 'transparentModal' fixed the issue where the screen behind the modal wasn't showing. Turns out this also solved the bug in calendar event creation, which was happening because the previous screen was unmounted and the complex chain of events that normally handles dismissing the ThreadPickerModal after the new Entry's TextInput is focused was malfunctioning as a result.

Test Plan

Confirm it's possible to creation a calendar event on Android without the TextInput immediately dismissing and the new Entry being auto-deleted as a result

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable