HomePhabricator
Diffusion Comm fbbb0b33690b

[5/n] Native Typeahead - Add selection state to chat input bar

Description

[5/n] Native Typeahead - Add selection state to chat input bar

Summary:
Preparing for native typeahead.
Adding selection to state so we can control it in input bars. There was a problem on iOS desribed here: https://linear.app/comm/issue/ENG-2367#comment-8e0f3042.
It was solved by adding controlSelection flag. We set it to false initially so we don't control
selection. It will be set true when we want to manipulate selection when inserting usernames after tapping into typeahead buttons (incoming diffs)

Test Plan:
Checked if app builds.
Checked if text input works corretly (both Android and iOS)

Reviewers: inka, ginsu, kamil, michal, tomek, ashoat

Reviewed By: tomek, ashoat

Subscribers: ashoat, tomek, atul, inka, ginsu, kamil, michal

Differential Revision: https://phab.comm.dev/D6367

Details

Provenance
przemekAuthored on Jan 13 2023, 6:15 AM
ashoatCommitted on Feb 7 2023, 2:36 PM
Reviewer
tomek
Differential Revision
D6367: [5/n] Native Typeahead - Add selection state to chat input bar
Parents
rCOMM9a5ad243ee32: [4.5/n] Native Typeahead - Refactoring to the common utility function
Branches
Unknown
Tags
Unknown