[web] wrap store operations in transaction
ClosedPublic
Actions

Authored by kamil on Nov 30 2023, 5:43 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM9d47f0a1a686: [web] wrap store operations in transaction

Summary

This is improvement and possible fix to: ENG-5910.

This is similar approach to native: link.

Test Plan

Run tests
Make sure persistence still works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 30 2023, 5:43 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 30 2023, 5:43 AM

Harbormaster completed remote builds in B24638: Diff 34050.Nov 30 2023, 6:02 AM

ashoat added inline comments.Nov 30 2023, 6:05 AM

web/database/worker/process-operations.js
85–114 ↗	(On Diff #34050)	I think this should all be in one transaction. See comment here: Arguably we should actually make all SQLite updates from a single Redux action get committed in a single transaction – today, even in `native` it appears that we wrap each individual store in its own transaction, rather than combining them together.

wrap everything in one transaction

web/database/worker/process-operations.js
85–114 ↗	(On Diff #34050)	I wanted to match native but this also seems reasonable

kamil published this revision for review.Nov 30 2023, 6:27 AM

Harbormaster completed remote builds in B24639: Diff 34051.Nov 30 2023, 6:46 AM

I think we should probably update native to match this too. Ultimately we're trying to match Redux behavior... because our master-reducer code has eg. MessageStore depending on ThreadStore, it's important that changes between the two are in sync

tomek accepted this revision.Nov 30 2023, 8:09 AM

This revision is now accepted and ready to land.Nov 30 2023, 8:09 AM

In D10097#294120, @ashoat wrote:

I think we should probably update native to match this too. Ultimately we're trying to match Redux behavior... because our master-reducer code has eg. MessageStore depending on ThreadStore, it's important that changes between the two are in sync

ENG-6004

Closed by commit rCOMM9d47f0a1a686: [web] wrap store operations in transaction (authored by kamil). · Explain WhyDec 1 2023, 6:24 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM9d47f0a1a686: [web] wrap store operations in transaction.