[web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscription
ClosedPublic
Actions

Authored by ashoat on Dec 1 2023, 4:21 AM.

Details

Reviewers

marcin
michal

Commits

rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in…

Summary

Context in ENG-6000. This diff fixes a regression introduced in D9970.

Test Plan

I deployed this fix to my keyserver in production and it resolved the issue described on Linear.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 1 2023, 4:21 AM

Herald added a subscriber: tomek. · View Herald TranscriptDec 1 2023, 4:21 AM

ashoat published this revision for review.Dec 1 2023, 4:23 AM

ashoat retitled this revision from [web] Don't crash if electron not defined in useCreateDesktopPushSubscription to [web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscription.Dec 1 2023, 4:26 AM

Harbormaster completed remote builds in B24676: Diff 34090.Dec 1 2023, 4:45 AM

marcin accepted this revision.Dec 1 2023, 9:01 AM

This revision is now accepted and ready to land.Dec 1 2023, 9:01 AM

Closed by commit rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in…. · Explain WhyDec 1 2023, 1:48 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in….

Revision Contents
Changeset List

Path

Size

web/

push-notif/

push-notifs-handler.js

2 lines

Diff 34103

View Options

web/push-notif/push-notifs-handler.js

[web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscriptionClosedPublicActions