[web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscription
ClosedPublic
Actions

Authored by ashoat on Nov 30 2023, 8:21 PM.

Details

Reviewers

marcin
michal

Commits

rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in…

Summary

Context in ENG-6000. This diff fixes a regression introduced in D9970.

Test Plan

I deployed this fix to my keyserver in production and it resolved the issue described on Linear.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 30 2023, 8:21 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 30 2023, 8:21 PM

ashoat published this revision for review.Nov 30 2023, 8:23 PM

ashoat retitled this revision from [web] Don't crash if electron not defined in useCreateDesktopPushSubscription to [web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscription.Nov 30 2023, 8:26 PM

Harbormaster completed remote builds in B24676: Diff 34090.Nov 30 2023, 8:45 PM

marcin accepted this revision.Dec 1 2023, 1:01 AM

This revision is now accepted and ready to land.Dec 1 2023, 1:01 AM

Closed by commit rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in… (authored by ashoat). · Explain WhyDec 1 2023, 5:48 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in….

Revision Contents
Changeset List

Path

Size

web/

push-notif/

push-notifs-handler.js

2 lines

Diff 34103

View Options

web/push-notif/push-notifs-handler.js

[web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscriptionClosedPublicActions