Page MenuHomePhabricator
Differential D10129

[web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscription
ClosedPublic
Actions

Authored by ashoat on Nov 30 2023, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 8:31 AM
Unknown Object (File)
Sun, Mar 23, 7:11 AM
Unknown Object (File)
Sun, Mar 23, 6:41 AM
Unknown Object (File)
Sun, Mar 23, 6:41 AM
Unknown Object (File)
Sun, Mar 23, 6:41 AM
Unknown Object (File)
Sat, Mar 22, 5:05 PM
Unknown Object (File)
Tue, Mar 18, 3:43 PM
Unknown Object (File)
Mar 9 2025, 7:21 PM
View All 67 Files
Subscribers
tomek

Details

Reviewers
marcin
michal
Commits
rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in…
Summary

Context in ENG-6000. This diff fixes a regression introduced in D9970.

Test Plan

I deployed this fix to my keyserver in production and it resolved the issue described on Linear.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 30 2023, 8:21 PM
Herald added a subscriber: tomek. · View Herald TranscriptNov 30 2023, 8:21 PM
ashoat published this revision for review.Nov 30 2023, 8:23 PM
ashoat retitled this revision from [web] Don't crash if electron not defined in useCreateDesktopPushSubscription to [web] Don't crash if electron.fetchDeviceToken not defined in useCreateDesktopPushSubscription.Nov 30 2023, 8:26 PM
Harbormaster completed remote builds in B24676: Diff 34090.Nov 30 2023, 8:45 PM
marcin accepted this revision.Dec 1 2023, 1:01 AM
This revision is now accepted and ready to land.Dec 1 2023, 1:01 AM
Closed by commit rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in… (authored by ashoat). · Explain WhyDec 1 2023, 5:48 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4b2eabc69d4a: [web] Don't crash if electron.fetchDeviceToken not defined in….

Revision Contents
Changeset List

PathSize
web/
push-notif/
2 lines

Diff 34103

View Options

web/push-notif/push-notifs-handler.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines