[keyserver] set default identity socket addr based on NODE_ENV value
ClosedPublic
Actions

Authored by varun on Dec 2 2023, 3:55 PM.

Details

Reviewers

bartek
ashoat

Commits

rCOMM888e93ecd987: [keyserver] set default identity socket addr based on NODE_ENV value

Summary

if NODE_ENV is "development", we try to connect to staging. if it's anything else, we try to connect to the prod identity service.

before landing this, i will let devs know that in order to talk to their local identity service, they'll now need to have a well-formed secrets/identity_service_config.json file or set the equivalent env var

Test Plan

ran yarn dev and connected to the staging instance

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Dec 2 2023, 3:55 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 2 2023, 3:55 PM

varun added a child revision: D10148: [keyserver] try to get identity config from file if env var is not present.Dec 2 2023, 3:57 PM

Harbormaster completed remote builds in B24717: Diff 34165.Dec 2 2023, 4:14 PM

varun requested review of this revision.Dec 2 2023, 4:14 PM

Makes sense to me but I don't know Rust – glad @bartek is a required reviewer

bartek accepted this revision.Dec 3 2023, 10:39 PM

bartek added inline comments.

keyserver/addons/rust-node-addon/src/identity_client/mod.rs
68–73 ↗	(On Diff #34165)	are there any good practices on whether consts should be local vs global scope?

This revision is now accepted and ready to land.Dec 3 2023, 10:39 PM

varun added inline comments.Dec 4 2023, 7:19 AM

keyserver/addons/rust-node-addon/src/identity_client/mod.rs
68–73 ↗	(On Diff #34165)	I think they should be global if they're going to be used in other places. in this case, i suppose the `ENV_` consts should be in the global scope, since there's a chance we might use them elsewhere. i don't think we'll use the `SOCKET_ADDR` consts anywhere else, though