Page MenuHomePhabricator
Differential D10204

[web] remove `CommQueryExecutor` code
ClosedPublic
Actions

Authored by kamil on Dec 6 2023, 2:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 4, 11:46 AM
Unknown Object (File)
Wed, Jul 3, 9:24 PM
Unknown Object (File)
Tue, Jul 2, 11:47 PM
Unknown Object (File)
Fri, Jun 28, 8:40 PM
Unknown Object (File)
Sat, Jun 22, 8:23 AM
Unknown Object (File)
Sat, Jun 22, 8:23 AM
Unknown Object (File)
Sat, Jun 22, 8:22 AM
Unknown Object (File)
May 31 2024, 11:21 AM
View All 24 Files
Subscribers
ashoat

Details

Reviewers
tomek
michal
Commits
rCOMM5294d9d74d14: [web] remove `CommQueryExecutor` code
Summary

It was introduced to test WASM on the web as entry point some time ago, right now we can remove it.

One additional thing we could consider is that we still refer to .wasm file as commQueryExecutorFilename while now it's SQLiteQueryExecutor, but not sure if changing it worth now.

Test Plan
  1. Flow
  2. Build Emscripten
  3. Make sure there is no errors on worker console

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
ios/
Comm.xcodeproj/
6 lines
web/
database/
_generated/
types/
2 lines
worker/
7 lines
scripts/

Diff 34414

View Options

native/cpp/CommonCpp/DatabaseManagers/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/CommQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/CommQueryExecutor.cpp

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

web/database/_generated/comm-query-executor.js

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...
View Options

web/database/types/comm-query-executor.js

Loading...
View Options

web/database/types/module.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...
View Options

web/scripts/run_emscripten.sh

Loading...