Page MenuHomePhabricator

[web] add missing `userID` param
ClosedPublic

Authored by kamil on Dec 7 2023, 8:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 9:08 AM
Unknown Object (File)
Nov 13 2024, 7:50 AM
Unknown Object (File)
Nov 13 2024, 7:50 AM
Unknown Object (File)
Nov 13 2024, 7:50 AM
Unknown Object (File)
Nov 13 2024, 7:50 AM
Unknown Object (File)
Nov 13 2024, 7:50 AM
Unknown Object (File)
Oct 13 2024, 3:48 PM
Unknown Object (File)
Oct 12 2024, 6:42 AM
Subscribers

Details

Summary

Context in ENG-5910.

Test Plan
  1. Stop processing thread store ops from reducer (to make sure logout does not fill state).
  2. Make sure table is empty.
  3. Reload app and check if threads are fetched from keyserver and persisted in DB.
  4. Reload again and threads should be read from DB.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Dec 7 2023, 8:18 AM

wondering if we should also update the type to avoid things like this or allow it since it's just the way Flow behaves cc. @michal @tomek

wondering if we should also update the type to avoid things like this

I think it makes sense to update the type to null | string, because we want flow to throw an error in this case

This revision is now accepted and ready to land.Dec 8 2023, 3:23 AM
This revision was automatically updated to reflect the committed changes.