Page MenuHomePhabricator
Differential D10222

[web] add missing `userID` param
ClosedPublic
Actions

Authored by kamil on Dec 7 2023, 8:11 AM.
Tags
None
Referenced Files
F2906052: D10222.diff
Sun, Oct 6, 8:57 AM
Unknown Object (File)
Sat, Sep 14, 5:09 PM
Unknown Object (File)
Sat, Sep 7, 9:27 AM
Unknown Object (File)
Sat, Sep 7, 9:27 AM
Unknown Object (File)
Sat, Sep 7, 9:27 AM
Unknown Object (File)
Fri, Sep 6, 10:28 PM
Unknown Object (File)
Aug 16 2024, 12:27 AM
Unknown Object (File)
Jul 29 2024, 7:42 AM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
tomek
michal
Commits
rCOMMa5741232c73f: [web] add missing `userID` param
Summary

Context in ENG-5910.

Test Plan
  1. Stop processing thread store ops from reducer (to make sure logout does not fill state).
  2. Make sure table is empty.
  3. Reload app and check if threads are fetched from keyserver and persisted in DB.
  4. Reload again and threads should be read from DB.

Diff Detail

Repository
rCOMM Comm
Branch
fix-threads-migration
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Dec 7 2023, 8:11 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptDec 7 2023, 8:11 AM
kamil published this revision for review.Dec 7 2023, 8:18 AM
Harbormaster completed remote builds in B24854: Diff 34376.Dec 7 2023, 9:01 AM
kamil added a comment.Dec 8 2023, 2:56 AM

wondering if we should also update the type to avoid things like this or allow it since it's just the way Flow behaves cc. @michal @tomek

michal accepted this revision.Dec 8 2023, 3:23 AM

wondering if we should also update the type to avoid things like this

I think it makes sense to update the type to null | string, because we want flow to throw an error in this case

This revision is now accepted and ready to land.Dec 8 2023, 3:23 AM
tomek accepted this revision.Dec 8 2023, 4:43 AM
kamil updated this revision to Diff 34422.Dec 8 2023, 5:46 AM

update param type

Harbormaster completed remote builds in B24892: Diff 34422.Dec 8 2023, 6:51 AM
Closed by commit rCOMMa5741232c73f: [web] add missing `userID` param (authored by kamil). · Explain WhyDec 8 2023, 6:55 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa5741232c73f: [web] add missing `userID` param.

Revision Contents
Changeset List

PathSize
web/
database/
utils/
2 lines
redux/
19 lines
5 lines

Diff 34422

View Options

web/database/utils/store.js

Loading...
View Options

web/redux/initial-state-gate.js

Loading...
View Options

web/redux/redux-setup.js

Loading...