[lib] Add runtime checks to `minimallyEncode*` utils to make sure argument isn't already minimally encoded
ClosedPublic
Actions

Authored by atul on Dec 15 2023, 4:27 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM8779efea689f: [lib] Add runtime checks to `minimallyEncode*` utils to make sure argument…

Summary

Similar to what we did in D10325 to minimallyEncodeThreadCurrentUserInfo, but for the rest of the minimallyEncode* utilities in minimally-encoded-thread-permissions-types.

These are more of a precaution than anything else.

Test Plan

Unit tests continue to pass.
Able to use app, go through Redux migration, etc without issue.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 15 2023, 4:27 PM

Harbormaster completed remote builds in B25128: Diff 34725.Dec 15 2023, 5:03 PM

atul requested review of this revision.Dec 15 2023, 5:03 PM

ashoat accepted this revision.Dec 15 2023, 5:17 PM

This revision is now accepted and ready to land.Dec 15 2023, 5:17 PM

Closed by commit rCOMM8779efea689f: [lib] Add runtime checks to `minimallyEncode*` utils to make sure argument…. · Explain WhyDec 15 2023, 5:24 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8779efea689f: [lib] Add runtime checks to `minimallyEncode*` utils to make sure argument….

Revision Contents
Changeset List

Path

Size

lib/

types/

minimally-encoded-thread-permissions-types.js

56 lines

Diff 34739

View Options

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Add runtime checks to `minimallyEncode*` utils to make sure argument isn't already minimally encodedClosedPublicActions