[lib] Update `useDisconnectedBarVisibilityHandler` to only consider `networkConnected`
AbandonedPublic
Actions

Authored by atul on Dec 27 2023, 7:42 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Summary

Update useDisconnectedBarVisibilityHandler to only consider network connectivity instead of keyserver connectivity.

Why don't we pull useSelector(state => state.connectivity.connected) into this hook?

We use state.connectivity.connected on native, but we use a separate approach for determining network connectivity on web (web/redux/disconnected-bar-visiblity-handler:useNetworkConnected()).

Test Plan

Stash changes
Kill local keyserver and ensure that DisconnectedBar appears as expected
Pop changes
Kill local keyserver and ensure that DisconnectedBar does not appear (and client has internet connectivity)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 27 2023, 7:42 AM

atul published this revision for review.Dec 27 2023, 7:58 AM

Going with a different approach. Instead of modifying eg useDisconnectedBarVisibilityHandler, I think it makes sense to keep them around for updating ConnectionInfo for keyservers in the KeyserverStore. Will rename them accordingly and introduce separate hooks that consume state => state.connectivity.connected on native and useNetworkConnected on web for displaying DisconnectedBar.

Harbormaster completed remote builds in B25344: Diff 35014.Dec 27 2023, 8:17 AM

atul abandoned this revision.Dec 28 2023, 2:22 AM

Revision Contents
Changeset List

Path

Size

lib/

hooks/

disconnected-bar.js

48 lines

Diff 35014

View Options

lib/hooks/disconnected-bar.js

[lib] Update `useDisconnectedBarVisibilityHandler` to only consider `networkConnected`AbandonedPublicActions