[web] Remove extraneous CSS selectors
ClosedPublic
Actions

Authored by atul on Jan 4 2024, 1:58 PM.

Details

Reviewers

ginsu

Commits

rCOMMb739a65caa71: [web] Remove extraneous CSS selectors

Summary

Context: https://phab.comm.dev/D10528#inline-64165

Quick 2 second diff. Ran IDE "Unused CSS selector" inspector to detect obvious unused CSS selectors. There were additional ones detected, I just selected the ones where there was no string match in codebase to be safe.

Test Plan

NA, searched codebase for the selector names and found no occurences.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 4 2024, 1:58 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 4 2024, 1:58 PM

atul published this revision for review.Jan 4 2024, 1:59 PM

atul mentioned this in D10528: [web] house the thread list in a panel component.

thanks for doing this!

This revision is now accepted and ready to land.Jan 4 2024, 2:04 PM

This revision was landed with ongoing or failed builds.Jan 4 2024, 2:09 PM

Closed by commit rCOMMb739a65caa71: [web] Remove extraneous CSS selectors (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb739a65caa71: [web] Remove extraneous CSS selectors.

Just a heads up I noticed that you removed the chat.css file, in my stack I use this file to add some styles. Just wanted to call this out since this seems like it could be a potential merge conflict

Harbormaster completed remote builds in B25510: Diff 35227.Jan 4 2024, 2:17 PM