Page MenuHomePhabricator
Differential D10553

[RN72] Update Babel
ClosedPublic
Actions

Authored by ashoat on Jan 5 2024, 6:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 8:46 AM
Unknown Object (File)
Fri, Mar 28, 4:46 PM
Unknown Object (File)
Wed, Mar 26, 4:47 PM
Unknown Object (File)
Tue, Mar 25, 5:19 PM
Unknown Object (File)
Sun, Mar 16, 12:10 AM
Unknown Object (File)
Sun, Mar 16, 12:10 AM
Unknown Object (File)
Sun, Mar 16, 12:10 AM
Unknown Object (File)
Sun, Mar 16, 12:09 AM
View All 76 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM5c109d342358: [RN72] Update Babel
Summary

As part of upgrading to React Native 0.72, react-native-upgrade-helper prompts us to update Babel.

Realized I forgot to do this as part of my stack yesterday.

Test Plan
  1. I ran web, landing, and keyserver in both prod and dev and clicked around to confirm things were working
  2. I built and ran iOS and Android locally and confirmed things work

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 5 2024, 6:46 AM
Herald added a subscriber: tomek. · View Herald TranscriptJan 5 2024, 6:46 AM
ashoat mentioned this in D10554: [native] Avoid calling invariant from worklet.Jan 5 2024, 7:12 AM
Harbormaster completed remote builds in B25539: Diff 35293.Jan 5 2024, 7:17 AM
ashoat requested review of this revision.Jan 5 2024, 7:17 AM
ashoat mentioned this in rCOMM6ca9199cd166: [native] Avoid calling invariant from worklet.Jan 5 2024, 8:33 AM
atul accepted this revision.Jan 5 2024, 12:37 PM
This revision is now accepted and ready to land.Jan 5 2024, 12:37 PM
atul added a comment.Jan 5 2024, 12:47 PM

Noticed a lot of repeated babel stuff when skimming the lock file. Ran yarn-deduplicate locally and got: https://gist.githubusercontent.com/atulsmadhugiri/95f82a4eafb53cffde598e92408e70c7/raw/31fad69447478cf8900df284de7f591675c56bd1/gistfile1.txt

Might be worth running at the end of this RN72 upgrade stack to reduce size of node_modules, etc

ashoat added a comment.Jan 5 2024, 3:49 PM

Good call. Created a follow-up task: ENG-6368

Closed by commit rCOMM5c109d342358: [RN72] Update Babel (authored by ashoat). · Explain WhyJan 5 2024, 3:51 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM5c109d342358: [RN72] Update Babel.

Revision Contents
Changeset List

PathSize
desktop/
16 lines
keyserver/
33 lines
landing/
22 lines
lib/
27 lines
native/
12 lines
web/
29 lines
1047 lines

Diff 35324

View Options

desktop/package.json

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

keyserver/package.json

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

landing/package.json

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

lib/package.json

Show All 16 Linesimport {
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult, type BlobServiceUploadResult,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
uploadMultimedia, uploadMultimedia,
useBlobServiceUpload, useBlobServiceUpload,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { import {
type SendMultimediaMessagePayload, type SendMultimediaMessagePayload,
useInputStateContainerSendMultimediaMessage, useInputStateContainerSendMultimediaMessage,
useInputStateContainerSendTextMessage, useInputStateContainerSendTextMessage,
} from 'lib/hooks/input-state-container-hooks.js'; } from 'lib/hooks/input-state-container-hooks.js';
import { useNewThickThread } from 'lib/hooks/thread-hooks.js'; import { useNewThickThread } from 'lib/hooks/thread-hooks.js';
import type { import type {
CallSingleKeyserverEndpointOptions, CallSingleKeyserverEndpointOptions,
Show All 14 Linesimport {
createMediaMessageInfo, createMediaMessageInfo,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getNextLocalID, getNextLocalID,
} from 'lib/shared/message-utils.js'; } from 'lib/shared/message-utils.js';
import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js'; import type { CreationSideEffectsFunc } from 'lib/shared/messages/message-spec.js';
import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js'; import { createRealThreadFromPendingThread } from 'lib/shared/thread-actions-utils.js';
import { import {
patchThreadInfoToIncludeMentionedMembersOfParent, patchThreadInfoToIncludeMentionedMembersOfParent,
threadInfoInsideCommunity,
threadIsPending, threadIsPending,
threadIsPendingSidebar, threadIsPendingSidebar,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import type { CalendarQuery } from 'lib/types/entry-types.js'; import type { CalendarQuery } from 'lib/types/entry-types.js';
import type { import type {
Media, Media,
MediaMission, MediaMission,
MediaMissionResult, MediaMissionResult,
▲ Show 20 Lines • Show All 562 Lines • ▼ Show 20 Lines try {
throw new SendMessageError( throw new SendMessageError(
`Exception when sending text message: ${exceptionMessage}`, `Exception when sending text message: ${exceptionMessage}`,
messageInfo.localID ?? '', messageInfo.localID ?? '',
messageInfo.threadID, messageInfo.threadID,
); );
} }
} }
// eslint-disable-next-line no-unused-vars
shouldEncryptMedia(threadInfo: ThreadInfo): boolean { shouldEncryptMedia(threadInfo: ThreadInfo): boolean {
return ( return true;
threadTypeIsThick(threadInfo.type) ||
threadInfoInsideCommunity(threadInfo, commStaffCommunity.id)
);
} }
bartekAuthorUnsubmitted
Done
Inline Actions

This function is removed in D13892

bartek: This function is removed in D13892
sendMultimediaMessage = async ( sendMultimediaMessage = async (
selections: $ReadOnlyArray<NativeMediaSelection>, selections: $ReadOnlyArray<NativeMediaSelection>,
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
) => { ) => {
this.sendCallbacks.forEach(callback => callback()); this.sendCallbacks.forEach(callback => callback());
const localMessageID = getNextLocalID(); const localMessageID = getNextLocalID();
void this.startThreadCreation(threadInfo); void this.startThreadCreation(threadInfo);
▲ Show 20 Lines • Show All 1,173 Lines • Show Last 20 Lines
View Options

native/package.json

Loading...
View Options

web/package.json

Loading...
View Options

yarn.lock

Loading...