Page MenuHomePhabricator

[RN72] Update Babel
ClosedPublic

Authored by ashoat on Jan 5 2024, 6:46 AM.
Tags
None
Referenced Files
F2776758: D10553.diff
Fri, Sep 20, 6:19 AM
F2765277: D10553.diff
Thu, Sep 19, 2:09 PM
Unknown Object (File)
Fri, Sep 6, 2:35 AM
Unknown Object (File)
Thu, Sep 5, 2:31 AM
Unknown Object (File)
Wed, Sep 4, 6:59 AM
Unknown Object (File)
Thu, Aug 29, 6:56 AM
Unknown Object (File)
Thu, Aug 29, 6:56 AM
Unknown Object (File)
Thu, Aug 29, 6:55 AM
Subscribers

Details

Summary

As part of upgrading to React Native 0.72, react-native-upgrade-helper prompts us to update Babel.

Realized I forgot to do this as part of my stack yesterday.

Test Plan
  1. I ran web, landing, and keyserver in both prod and dev and clicked around to confirm things were working
  2. I built and ran iOS and Android locally and confirmed things work

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Jan 5 2024, 7:17 AM
This revision is now accepted and ready to land.Jan 5 2024, 12:37 PM

Noticed a lot of repeated babel stuff when skimming the lock file. Ran yarn-deduplicate locally and got: https://gist.githubusercontent.com/atulsmadhugiri/95f82a4eafb53cffde598e92408e70c7/raw/31fad69447478cf8900df284de7f591675c56bd1/gistfile1.txt

Might be worth running at the end of this RN72 upgrade stack to reduce size of node_modules, etc

Good call. Created a follow-up task: ENG-6368

This revision was automatically updated to reflect the committed changes.