Page MenuHomePhabricator

[lib] Introduce canResolveKeyserverSessionInvalidation
ClosedPublic

Authored by ashoat on Jan 8 2024, 9:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 9:17 AM
Unknown Object (File)
Oct 17 2024, 3:03 PM
Unknown Object (File)
Oct 17 2024, 3:03 PM
Unknown Object (File)
Oct 17 2024, 3:03 PM
Unknown Object (File)
Oct 17 2024, 3:02 PM
Unknown Object (File)
Oct 17 2024, 3:02 PM
Unknown Object (File)
Sep 6 2024, 6:04 AM
Unknown Object (File)
Sep 6 2024, 6:04 AM
Subscribers
None

Details

Summary

Previously, to figure out if it was possible to resolve a keyserver session invalidation, we were checking for the presence of the resolveInvalidatedCookie function.

That function was missing on web but present on native, since it required native credentials to work.

Now we can attempt resolution for any client that is usingCommServicesAccessToken, so we want to update the check. Instead of duplicating the code, I introduced a function to handle the check.

Depends on D10577

Test Plan

Will test this by triggering a session invalidation by deleting a cookie from the MariaDB database

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2024, 10:27 AM
Harbormaster failed remote builds in B25613: Diff 35408!
inka added inline comments.
lib/utils/action-utils.js
193–194 ↗(On Diff #35408)

I don't think this is exactly true - we can always try, but it might fail

This revision is now accepted and ready to land.Jan 9 2024, 3:15 AM