Page MenuHomePhabricator
Differential D10599

[lib][web][native] rename changeUserPassword -> changeKeyserverUserPassword
ClosedPublic
Actions

Authored by varun on Jan 10 2024, 8:58 PM.
Tags
None
Referenced Files
F2193606: D10599.diff
Thu, Jul 4, 10:37 PM
Unknown Object (File)
Sun, Jun 30, 2:40 AM
Unknown Object (File)
Wed, Jun 26, 7:41 PM
Unknown Object (File)
Tue, Jun 25, 3:10 PM
Unknown Object (File)
Mon, Jun 24, 11:44 AM
Unknown Object (File)
Sun, Jun 23, 11:24 PM
Unknown Object (File)
Sun, Jun 23, 11:10 PM
Unknown Object (File)
Sat, Jun 22, 6:35 AM
View All 32 Files
Subscribers
None

Details

Reviewers
tomek
inka
ashoat
Commits
rCOMM12fb3477769b: [lib][web][native] rename changeUserPassword -> changeKeyserverUserPassword
Summary

before introducing a new action changeIdentityUserPassword, we need to rename the existing one to avoid confusion

Test Plan

no flow errors

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jan 10 2024, 8:58 PM
varun updated this revision to Diff 35511.Jan 10 2024, 9:03 PM

change action type names

Harbormaster completed remote builds in B25686: Diff 35510.Jan 10 2024, 9:23 PM
Harbormaster completed remote builds in B25687: Diff 35511.Jan 10 2024, 9:27 PM
varun requested review of this revision.Jan 10 2024, 9:27 PM
tomek accepted this revision.Jan 11 2024, 12:39 AM
tomek added inline comments.
web/settings/password-change-modal.js
244 ↗(On Diff #35511)
257 ↗(On Diff #35511)
This revision is now accepted and ready to land.Jan 11 2024, 12:39 AM
Closed by commit rCOMM12fb3477769b: [lib][web][native] rename changeUserPassword -> changeKeyserverUserPassword (authored by varun). · Explain WhyJan 11 2024, 11:13 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM12fb3477769b: [lib][web][native] rename changeUserPassword -> changeKeyserverUserPassword.

Revision Contents
Changeset List

PathSize
lib/
actions/
14 lines
types/
6 lines
native/
profile/
20 lines
web/
settings/
26 lines

Diff 35561

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/profile/edit-password.react.js

Loading...
View Options

web/settings/password-change-modal.js

Loading...