Page MenuHomePhabricator
Differential D10669

[native_rust_library] fix display text for error enum
ClosedPublic
Actions

Authored by varun on Jan 17 2024, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 9:54 AM
Unknown Object (File)
Thu, Apr 17, 9:16 AM
Unknown Object (File)
Thu, Apr 17, 8:26 AM
Unknown Object (File)
Wed, Apr 16, 5:24 AM
Unknown Object (File)
Fri, Apr 11, 7:59 AM
Unknown Object (File)
Wed, Apr 9, 12:47 AM
Unknown Object (File)
Feb 20 2025, 6:41 PM
Unknown Object (File)
Feb 20 2025, 6:41 PM
View All 71 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
Commits
rCOMMdd7577640d5d: [native_rust_library] fix display text for error enum
Summary

small change to improve the error strings we send back to JS

Test Plan

console logged the TonicGRPC error variant in JS and confirmed it only contained the gRPC message and no extraneous info

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
7 lines

Diff 35737

View Options

native/native_rust_library/src/lib.rs

  • This file was added.
// @flow
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMSendMultimediaMessageOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { MediaMessageData } from '../../types/messages/media.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(
dmOperation: DMSendMultimediaMessageOperation,
): MediaMessageData {
const { threadID, creatorID, time, media } = dmOperation;
return {
type: messageTypes.MULTIMEDIA,
threadID,
creatorID,
time,
media,
};
}
const sendMultimediaMessageSpec: DMOperationSpec<DMSendMultimediaMessageOperation> =
Object.freeze({
notificationsCreationData: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] };
},
processDMOperation: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const { messageID } = dmOperation;
const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID),
];
const updateInfos: Array<ClientUpdateInfo> = [];
return {
rawMessageInfos,
updateInfos,
};
},
canBeProcessed(
dmOperation: DMSendMultimediaMessageOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) {
if (utilities.threadInfos[dmOperation.threadID]) {
return { isProcessingPossible: true };
}
return {
isProcessingPossible: false,
reason: {
type: 'missing_thread',
threadID: dmOperation.threadID,
},
};
},
supportsAutoRetry: false,
});
export { sendMultimediaMessageSpec };