[keyserver] Use verifyUserLoggedIn instead of fetchIdentityInfo in versionResponseValidator
ClosedPublic
Actions

Authored by ashoat on Jan 18 2024, 11:14 AM.

Details

Reviewers

varun
inka

Commits

rCOMM310cb2b5c29b: [keyserver] Use verifyUserLoggedIn instead of fetchIdentityInfo in…

Summary

verifyUserLoggedIn returns the same thing as fetchIdentityInfo. The difference is that verifyUserLoggedIn will attempt identity login if the identity info is not present in MariaDB.

This makes it a bit more convenient to be able to eg. clear the identity info from MariaDB to force a re-login, which came up in ENG-6466.

Test Plan

Flow
Careful reading of the code for verifyUserLoggedIn
An observation of what happened when I restarted my keyserver after clearing the identity info from MariaDB (restart triggered running verifyUserLoggedIn)

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/ident

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 18 2024, 11:14 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 18 2024, 11:14 AM

i wonder if we should use verifyUserLoggedIn instead of fetchIdentityInfo in other places as well (keyserverAuthResponder, publishPrekeysToIdentity)

Harbormaster completed remote builds in B25916: Diff 35836.Jan 18 2024, 11:36 AM

ashoat requested review of this revision.Jan 18 2024, 11:36 AM

varun accepted this revision.Jan 18 2024, 11:45 AM

This revision is now accepted and ready to land.Jan 18 2024, 11:45 AM

Good call. Also got uploadNewOneTimeKeys

Update other fetchIdentityInfo callsites to verifyUserLoggedIn

Harbormaster completed remote builds in B25922: Diff 35842.Jan 18 2024, 12:36 PM

Closed by commit rCOMM310cb2b5c29b: [keyserver] Use verifyUserLoggedIn instead of fetchIdentityInfo in… (authored by ashoat). · Explain WhyJan 18 2024, 12:43 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM310cb2b5c29b: [keyserver] Use verifyUserLoggedIn instead of fetchIdentityInfo in….