[nix] Revert protoc-gen-grpc-web to 1.4.2 using overlay
ClosedPublic
Actions

Authored by will on Jan 18 2024, 10:53 PM.

Details

Reviewers

varun
bartek

Commits

rCOMMb37c2c5d8d5b: [nix] Revert protoc-gen-grpc-web to 1.4.2 using overlay

Summary

This creates an overlay with the last nixpkgs revision 9957cd48326fe8dbd52fdc50dd2502307f188b0d to have grpc-web version 1.4.2
and replaces the dev-shell installation which uses the latest nixpkgs-unstable grpc-web package.

Test Plan

Successfully ran nix develop and it installed 1.4.2 properly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 18 2024, 10:53 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 10:54 PM

will edited the summary of this revision. (Show Details)Jan 18 2024, 10:54 PM

Harbormaster completed remote builds in B25945: Diff 35867.Jan 18 2024, 11:13 PM

will requested review of this revision.Jan 18 2024, 11:13 PM

Thanks for putting this out so quickly! Unfortunately, it seems like there's still a problem:

varun@varuns-MacBook-Pro web % yarn codegen-identity-grpc        
yarn run v1.22.19
$ ./scripts/codegen-identity-grpc.sh
/nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: /nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: cannot execute binary file
--grpc-web_out: protoc-gen-grpc-web: Plugin failed with status code 126.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I think the protoc-gen-grpc-web binary you added is compiled for a different architecture

This revision now requires changes to proceed.Jan 18 2024, 11:34 PM

After yarn arc-patching this diff:

varun@varuns-MacBook-Pro web % file /nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web
/nix/store/7qj55bw020lvz0246lbz2ap7ji6sd275-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /nix/store/ld03l52xq2ssn4x0g5asypsxqls40497-glibc-2.37-8/lib/ld-linux-x86-64.so.2, for GNU/Linux 3.10.0, not stripped

After checking out an old commit from before protoc-gen-grpc-web was upgraded to 1.5.0:

varun@varuns-MacBook-Pro web % file /nix/store/048hbnyjjg6r86k92nsbmvcq736bvn5k-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web
/nix/store/048hbnyjjg6r86k92nsbmvcq736bvn5k-protoc-gen-grpc-web-1.4.2/bin/protoc-gen-grpc-web: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>

varun added inline comments.Jan 18 2024, 11:40 PM