Page MenuHomePhabricator

[web] implementing getting outbound user keys in `IdentityServiceClient`
ClosedPublic

Authored by kamil on Jan 22 2024, 2:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:37 AM
Unknown Object (File)
Mon, Jul 1, 11:37 AM
Unknown Object (File)
Mon, Jul 1, 12:47 AM
Unknown Object (File)
Sat, Jun 29, 8:03 PM
Unknown Object (File)
Sat, Jun 29, 6:17 PM
Subscribers

Details

Summary

Call RPC to get the keys of all devices of a given user.

This approach is different, we want to:

  1. Return all user devices
  2. Return valid user keys even though one device has for example missing one-time keys

    Depends on D10748
Test Plan

Call method and log result

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jan 22 2024, 4:37 AM
tomek added inline comments.
web/grpc/identity-service-client-wrapper.js
141 ↗(On Diff #35904)

Shouldn't we check if it is an array?

187 ↗(On Diff #35904)

Shouldn't we check the type of deviceID?

This revision is now accepted and ready to land.Jan 22 2024, 8:11 AM
This revision was landed with ongoing or failed builds.Jan 29 2024, 2:00 AM
This revision was automatically updated to reflect the committed changes.