Page MenuHomePhabricator
Differential D10749

[web] implementing getting outbound user keys in `IdentityServiceClient`
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 2:18 AM.
Tags
None
Referenced Files
F6045808: D10749.id35904.diff
Sun, Apr 20, 4:36 AM
Unknown Object (File)
Wed, Apr 9, 12:27 AM
Unknown Object (File)
Tue, Apr 8, 8:35 PM
Unknown Object (File)
Tue, Apr 8, 7:57 PM
Unknown Object (File)
Tue, Apr 8, 7:54 PM
Unknown Object (File)
Tue, Apr 1, 3:58 AM
Unknown Object (File)
Sun, Mar 30, 4:53 PM
Unknown Object (File)
Mar 13 2025, 7:36 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
varun
Commits
rCOMM901cb3bc1c1e: [web] implementing getting outbound user keys in `IdentityServiceClient`
Summary

Call RPC to get the keys of all devices of a given user.

This approach is different, we want to:

  1. Return all user devices
  2. Return valid user keys even though one device has for example missing one-time keys

    Depends on D10748
Test Plan

Call method and log result

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jan 22 2024, 2:18 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJan 22 2024, 2:18 AM
kamil edited the summary of this revision. (Show Details)Jan 22 2024, 2:21 AM
kamil added a child revision: D10750: [native] implementing getting outbound user keys in `IdentityServiceClient`.Jan 22 2024, 2:21 AM
Harbormaster failed remote builds in B25972: Diff 35904!Jan 22 2024, 2:48 AM
kamil published this revision for review.Jan 22 2024, 4:37 AM
tomek accepted this revision.Jan 22 2024, 8:11 AM
tomek added inline comments.
web/grpc/identity-service-client-wrapper.js
141 ↗(On Diff #35904)

Shouldn't we check if it is an array?

187 ↗(On Diff #35904)

Shouldn't we check the type of deviceID?

This revision is now accepted and ready to land.Jan 22 2024, 8:11 AM
kamil updated this revision to Diff 36209.Jan 27 2024, 6:41 AM

add checks

Harbormaster failed remote builds in B26216: Diff 36209!Jan 27 2024, 6:48 AM
This revision was landed with ongoing or failed builds.Jan 29 2024, 2:00 AM
Closed by commit rCOMM901cb3bc1c1e: [web] implementing getting outbound user keys in `IdentityServiceClient` (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM901cb3bc1c1e: [web] implementing getting outbound user keys in `IdentityServiceClient`.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines
web/
grpc/
79 lines

Diff 36231

View Options

lib/types/identity-service-types.js

Show All 25 Lines
import type { ClientDBMessageInfo } from 'lib/types/message-types.js'; import type { ClientDBMessageInfo } from 'lib/types/message-types.js';
import { cookieTypes } from 'lib/types/session-types.js'; import { cookieTypes } from 'lib/types/session-types.js';
import { defaultConnectionInfo } from 'lib/types/socket-types.js'; import { defaultConnectionInfo } from 'lib/types/socket-types.js';
import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js'; import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js';
import type { ClientDBThreadInfo } from 'lib/types/thread-types.js'; import type { ClientDBThreadInfo } from 'lib/types/thread-types.js';
import { getConfig } from 'lib/utils/config.js'; import { getConfig } from 'lib/utils/config.js';
import { parseCookies } from 'lib/utils/cookie-utils.js'; import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { wipeKeyserverStore } from 'lib/utils/keyserver-store-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { entries } from 'lib/utils/objects.js'; import { entries } from 'lib/utils/objects.js';
import { resetUserSpecificState } from 'lib/utils/reducers-utils.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo, convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
} from 'lib/utils/thread-ops-utils.js'; } from 'lib/utils/thread-ops-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
import { defaultWebState } from './default-state.js'; import {
handleReduxMigrationFailure,
persistWhitelist,
} from './handle-redux-migration-failure.js';
import { rootKey, rootKeyPrefix } from './persist-constants.js'; import { rootKey, rootKeyPrefix } from './persist-constants.js';
import type { AppState } from './redux-setup.js'; import type { AppState } from './redux-setup.js';
import { nonUserSpecificFieldsWeb } from './redux-setup.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js'; import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js';
import { getOlmWasmPath } from '../shared-worker/utils/constants.js'; import { getOlmWasmPath } from '../shared-worker/utils/constants.js';
import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js'; import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js';
import { workerRequestMessageTypes } from '../types/worker-types.js'; import { workerRequestMessageTypes } from '../types/worker-types.js';
declare var keyserverURL: string; declare var keyserverURL: string;
const persistWhitelist = [
'enabledApps',
'alertStore',
'commServicesAccessToken',
'keyserverStore',
'globalThemeInfo',
'customServer',
'messageStore',
];
function handleReduxMigrationFailure(oldState: AppState): AppState {
const persistedNonUserSpecificFields = nonUserSpecificFieldsWeb.filter(
field => persistWhitelist.includes(field) || field === '_persist',
);
const stateAfterReset = resetUserSpecificState(
oldState,
defaultWebState,
persistedNonUserSpecificFields,
);
return {
...stateAfterReset,
keyserverStore: wipeKeyserverStore(stateAfterReset.keyserverStore),
};
}
const migrations = { const migrations = {
[1]: async (state: any) => { [1]: async (state: any) => {
const { const {
primaryIdentityPublicKey, primaryIdentityPublicKey,
...stateWithoutPrimaryIdentityPublicKey ...stateWithoutPrimaryIdentityPublicKey
} = state; } = state;
return { return {
...stateWithoutPrimaryIdentityPublicKey, ...stateWithoutPrimaryIdentityPublicKey,
▲ Show 20 Lines • Show All 453 Lines • Show Last 20 Lines
View Options

web/grpc/identity-service-client-wrapper.js

Show All 25 Lines
import type { ClientDBMessageInfo } from 'lib/types/message-types.js'; import type { ClientDBMessageInfo } from 'lib/types/message-types.js';
import { cookieTypes } from 'lib/types/session-types.js'; import { cookieTypes } from 'lib/types/session-types.js';
import { defaultConnectionInfo } from 'lib/types/socket-types.js'; import { defaultConnectionInfo } from 'lib/types/socket-types.js';
import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js'; import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js';
import type { ClientDBThreadInfo } from 'lib/types/thread-types.js'; import type { ClientDBThreadInfo } from 'lib/types/thread-types.js';
import { getConfig } from 'lib/utils/config.js'; import { getConfig } from 'lib/utils/config.js';
import { parseCookies } from 'lib/utils/cookie-utils.js'; import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { wipeKeyserverStore } from 'lib/utils/keyserver-store-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { entries } from 'lib/utils/objects.js'; import { entries } from 'lib/utils/objects.js';
import { resetUserSpecificState } from 'lib/utils/reducers-utils.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo, convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
} from 'lib/utils/thread-ops-utils.js'; } from 'lib/utils/thread-ops-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
import { defaultWebState } from './default-state.js'; import {
handleReduxMigrationFailure,
persistWhitelist,
} from './handle-redux-migration-failure.js';
import { rootKey, rootKeyPrefix } from './persist-constants.js'; import { rootKey, rootKeyPrefix } from './persist-constants.js';
import type { AppState } from './redux-setup.js'; import type { AppState } from './redux-setup.js';
import { nonUserSpecificFieldsWeb } from './redux-setup.js';
import { authoritativeKeyserverID } from '../authoritative-keyserver.js'; import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js'; import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js';
import { getOlmWasmPath } from '../shared-worker/utils/constants.js'; import { getOlmWasmPath } from '../shared-worker/utils/constants.js';
import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js'; import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js';
import { workerRequestMessageTypes } from '../types/worker-types.js'; import { workerRequestMessageTypes } from '../types/worker-types.js';
declare var keyserverURL: string; declare var keyserverURL: string;
const persistWhitelist = [
'enabledApps',
'alertStore',
'commServicesAccessToken',
'keyserverStore',
'globalThemeInfo',
'customServer',
'messageStore',
];
function handleReduxMigrationFailure(oldState: AppState): AppState {
const persistedNonUserSpecificFields = nonUserSpecificFieldsWeb.filter(
field => persistWhitelist.includes(field) || field === '_persist',
);
const stateAfterReset = resetUserSpecificState(
oldState,
defaultWebState,
persistedNonUserSpecificFields,
);
return {
...stateAfterReset,
keyserverStore: wipeKeyserverStore(stateAfterReset.keyserverStore),
};
}
const migrations = { const migrations = {
[1]: async (state: any) => { [1]: async (state: any) => {
const { const {
primaryIdentityPublicKey, primaryIdentityPublicKey,
...stateWithoutPrimaryIdentityPublicKey ...stateWithoutPrimaryIdentityPublicKey
} = state; } = state;
return { return {
...stateWithoutPrimaryIdentityPublicKey, ...stateWithoutPrimaryIdentityPublicKey,
▲ Show 20 Lines • Show All 453 Lines • Show Last 20 Lines