Page MenuHomePhabricator

[lib][keyserver] Extract rawThreadInfo validators into their own file
ClosedPublic

Authored by ashoat on Feb 5 2024, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 5:53 AM
Unknown Object (File)
Mon, Dec 23, 5:53 AM
Unknown Object (File)
Mon, Dec 23, 5:53 AM
Unknown Object (File)
Mon, Dec 23, 5:53 AM
Unknown Object (File)
Mon, Dec 23, 5:53 AM
Unknown Object (File)
Mon, Dec 23, 5:53 AM
Unknown Object (File)
Wed, Dec 18, 11:16 AM
Unknown Object (File)
Sat, Dec 14, 12:14 PM
Subscribers

Details

Summary

After adding an import of socket-types.js to call-keyserver-endpoint-provider.js in a later diff, I encountered an import cycle that was triggered by yarn test in lib.

I found a way to resolve it by extracting the rawThreadInfo validators into their own file. Now it's possible to import the rawThreadInfo validators without triggering an import of threadEntityValidator from entity-text.js. I didn't follow the mystery further than that... entity-text.js imports a lot of utils, so I guessed that this change would solve the issue.

NOTE: I also renamed MemberInfoValidator to memberInfoValidator here, for consistency with the rest of the codebase.
NOTE: I ended up having another import cycle that I had to resolve, and after resolving that one, this diff was no longer necessary to resolve the first import cycle. That said, I still thought it was a good idea to put this diff up, in case the same code is involved in another import cycle later.

Depends on D10952

Test Plan
  1. Test successful session invalidation in single keyserver world
    1. I prevented the Socket from rendering by adding a return null line before the other returns in KeyserverConnectionHandler. This avoided the Socket triggering session recovery.
    2. I started the iOS simulator and logged in using a test user.
    3. I opened the Redux Dev Tools
    4. I deleted the test user's cookie from the MariaDB database: DELETE FROM cookies WHERE user = 6390578 AND platform = 'ios'
    5. I sent a message as the test user
    6. I confirmed that session recovery was triggered in the Redux dev tools (and through some console logs)
    7. I repeated the process above several times to make sure it consistently worked multiple times in a single run
    8. I confirmed that the message was delivered "transparently" (without any visible issues, or evidence of session invalidation)
  2. Test failed session invalidation in single keyserver world
    1. I ran through the above test, but I hacked legacy-recover-keyserver-session.js to use the wrong password so the session recovery would fail
    2. I confirmed that I was logged out, and that an alert appeared explaining that my session was invalidated
  3. Test logging out during session recovery
    1. I triggered an infinite loop of session recoveries by running through the above test, but swallowing the SET_NEW_SESSION
    2. I logged out of the app
    3. I confirmed that the session recovery loop stopped, and that I was logged out successfully

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Feb 5 2024, 1:14 PM

Thanks for fixing that capitalization issue

This revision is now accepted and ready to land.Feb 6 2024, 7:17 AM