Page MenuHomePhabricator
Differential D10966

[lib] refactor `keyserverStoreOpsHandlers` to process ops on entire KeyserverStore
ClosedPublic
Actions

Authored by kamil on Feb 6 2024, 5:48 AM.
Tags
None
Referenced Files
F3280275: D10966.id36873.diff
Sat, Nov 16, 9:06 AM
F3276057: D10966.diff
Sat, Nov 16, 7:20 AM
Unknown Object (File)
Wed, Nov 6, 8:05 PM
Unknown Object (File)
Oct 15 2024, 12:01 PM
Unknown Object (File)
Oct 15 2024, 12:01 PM
Unknown Object (File)
Oct 15 2024, 12:01 PM
Unknown Object (File)
Oct 15 2024, 12:00 PM
Unknown Object (File)
Oct 15 2024, 12:00 PM
View All 48 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMM8f5445cf7c9b: [lib] refactor `keyserverStoreOpsHandlers` to process ops on entire…
Summary

Context here: https://phab.comm.dev/D10934#inline-66526.
This was also suggested here: https://phab.comm.dev/D10755#inline-65783

Test Plan

Flow - this is just a refactor

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Feb 6 2024, 5:48 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 6 2024, 5:48 AM
kamil mentioned this in D10934: [lib] refactor keyserver-related actions in `master-reducer` to ops.Feb 6 2024, 5:49 AM
kamil published this revision for review.Feb 6 2024, 6:00 AM
Harbormaster completed remote builds in B26553: Diff 36691.Feb 6 2024, 6:05 AM
inka accepted this revision.Feb 7 2024, 4:45 AM

Thank you!

lib/reducers/master-reducer.js
133 ↗(On Diff #36691)

I think we can remove this if now

This revision is now accepted and ready to land.Feb 7 2024, 4:45 AM
kamil updated this revision to Diff 36871.Feb 8 2024, 10:33 AM

address review & rebase

Harbormaster failed remote builds in B26663: Diff 36871!Feb 8 2024, 10:36 AM
This revision was landed with ongoing or failed builds.Feb 8 2024, 10:44 AM
Closed by commit rCOMM8f5445cf7c9b: [lib] refactor `keyserverStoreOpsHandlers` to process ops on entire… (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM8f5445cf7c9b: [lib] refactor `keyserverStoreOpsHandlers` to process ops on entire….

Revision Contents
Changeset List

PathSize
lib/
ops/
13 lines
reducers/
117 lines
14 lines
web/
redux/
22 lines

Diff 36873

View Options

lib/ops/keyserver-store-ops.js

Loading...
View Options

lib/reducers/keyserver-reducer.js

Loading...
View Options

lib/reducers/master-reducer.js

Loading...
View Options

web/redux/redux-setup.js

Loading...