[lib] refactor `keyserverStoreOpsHandlers` to process ops on entire KeyserverStore
ClosedPublic
Actions

Authored by kamil on Feb 6 2024, 5:48 AM.

Details

Reviewers

Commits

rCOMM8f5445cf7c9b: [lib] refactor `keyserverStoreOpsHandlers` to process ops on entire…

Summary

Context here: https://phab.comm.dev/D10934#inline-66526.
This was also suggested here: https://phab.comm.dev/D10755#inline-65783

Test Plan

Flow - this is just a refactor

Diff Detail

Repository

rCOMM Comm

Branch

refactor-ks-ops

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Feb 6 2024, 5:48 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 6 2024, 5:48 AM

kamil mentioned this in D10934: [lib] refactor keyserver-related actions in `master-reducer` to ops.Feb 6 2024, 5:49 AM

kamil published this revision for review.Feb 6 2024, 6:00 AM

Harbormaster completed remote builds in B26553: Diff 36691.Feb 6 2024, 6:05 AM

Thank you!

lib/reducers/master-reducer.js
133	I think we can remove this if now

This revision is now accepted and ready to land.Feb 7 2024, 4:45 AM

address review & rebase

Harbormaster failed remote builds in B26663: Diff 36871!Feb 8 2024, 10:36 AM

This revision was landed with ongoing or failed builds.Feb 8 2024, 10:44 AM

Closed by commit rCOMM8f5445cf7c9b: [lib] refactor `keyserverStoreOpsHandlers` to process ops on entire… (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM8f5445cf7c9b: [lib] refactor `keyserverStoreOpsHandlers` to process ops on entire….

Revision Contents
Changeset List

Path

Size

lib/

ops/

keyserver-store-ops.js

13 lines

reducers/

keyserver-reducer.js

112 lines

master-reducer.js

11 lines

web/

redux/

redux-setup.js

22 lines

Diff 36691

View Options

lib/ops/keyserver-store-ops.js

View Options

lib/reducers/keyserver-reducer.js

View Options

lib/reducers/master-reducer.js

View Options

[lib] refactor `keyserverStoreOpsHandlers` to process ops on entire KeyserverStoreClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36691

lib/ops/keyserver-store-ops.js

lib/reducers/keyserver-reducer.js

lib/reducers/master-reducer.js

web/redux/redux-setup.js

[lib] refactor `keyserverStoreOpsHandlers` to process ops on entire KeyserverStore
ClosedPublic
Actions

Revision Contents
Changeset List