Page MenuHomePhabricator
Differential D10967

[CI] Use M1 runners for macOS-based GH Actions workflows
ClosedPublic
Actions

Authored by atul on Feb 6 2024, 10:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 12:44 AM
Unknown Object (File)
Fri, Jun 21, 12:43 AM
Unknown Object (File)
Fri, Jun 14, 5:38 AM
Unknown Object (File)
Apr 8 2024, 7:26 AM
Unknown Object (File)
Apr 8 2024, 7:26 AM
Unknown Object (File)
Apr 8 2024, 7:26 AM
Unknown Object (File)
Apr 8 2024, 7:26 AM
Unknown Object (File)
Apr 8 2024, 7:26 AM
View All 24 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM540d603fd873: [CI] Use M1 runners for macOS-based GH Actions workflows
Summary

Context: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

Should speed up iOS/macOS builds and reduce time from kicking off release to it being available via Internal TestFlight.

Test Plan

Hoping that it just works, will revert if any issues arise.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 6 2024, 10:21 AM
atul added inline comments.Feb 6 2024, 10:22 AM
.github/workflows/ios_ci.yml
15–16 ↗(On Diff #36721)

15.0.1 is default on Sonoma runners, so we can cut this.

atul published this revision for review.Feb 6 2024, 10:22 AM
ashoat accepted this revision.Feb 6 2024, 10:26 AM

Can you wait on ENG-6685 being resolved before landing? I think it should be simple... can take a look in the next hour

This revision is now accepted and ready to land.Feb 6 2024, 10:26 AM
atul added a comment.Feb 6 2024, 10:34 AM
In D10967#316438, @ashoat wrote:

Can you wait on ENG-6685 being resolved before landing? I think it should be simple... can take a look in the next hour

Yeah will do

Harbormaster completed remote builds in B26573: Diff 36721.Feb 6 2024, 10:37 AM
atul updated this revision to Diff 36749.Feb 6 2024, 1:53 PM

land

Harbormaster completed remote builds in B26593: Diff 36749.Feb 6 2024, 2:13 PM
Closed by commit rCOMM540d603fd873: [CI] Use M1 runners for macOS-based GH Actions workflows (authored by atul). · Explain WhyFeb 7 2024, 7:32 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM540d603fd873: [CI] Use M1 runners for macOS-based GH Actions workflows.
atul added a comment.Feb 29 2024, 12:48 PM

Forgot this was landed, looks like it brought iOS build times down to ~13-14min from ~50min

ashoat added a comment.Feb 29 2024, 2:03 PM

Nice!!

Revision Contents
Changeset List

PathSize
.github/
workflows/
5 lines
5 lines
2 lines

Diff 36781

View Options

.github/workflows/ios_ci.yml

Loading...
View Options

.github/workflows/ios_release.yml

Loading...
View Options

.github/workflows/macos_ci.yml

Loading...