Page MenuHomePhabricator
Differential D10983

[native] rename MessageResultsScreen to PinnedMessagesScreen
ClosedPublic
Actions

Authored by ginsu on Feb 7 2024, 12:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 11:45 PM
Unknown Object (File)
Apr 8 2024, 11:45 PM
Unknown Object (File)
Apr 8 2024, 11:45 PM
Unknown Object (File)
Apr 8 2024, 11:43 PM
Unknown Object (File)
Apr 7 2024, 2:59 AM
Unknown Object (File)
Mar 16 2024, 7:58 PM
Unknown Object (File)
Feb 21 2024, 1:15 AM
Unknown Object (File)
Feb 20 2024, 11:27 PM
View All 20 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM9630b275ef41: [native] rename MessageResultsScreen to PinnedMessagesScreen
Summary

In D10345 I got some feedback to update the MessageResultsScreen to PinnedMessagesScreen

Linear task: https://linear.app/comm/issue/ENG-6356/rename-messageresultsscreen-on-native-to-be-pinned-messages-screen

Test Plan

flow + confirmed PinnedMessagesScreen has no regressions

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 7 2024, 12:52 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 7 2024, 12:52 AM
ginsu edited the summary of this revision. (Show Details)Feb 7 2024, 12:53 AM
ginsu added reviewers: atul, inka.
Harbormaster completed remote builds in B26611: Diff 36768.Feb 7 2024, 1:20 AM
ginsu requested review of this revision.Feb 7 2024, 1:20 AM
atul accepted this revision.Feb 7 2024, 12:58 PM

Skimmed, assuming this is straightforward refactor.

This revision is now accepted and ready to land.Feb 7 2024, 12:58 PM
ginsu updated this revision to Diff 36808.Feb 7 2024, 1:51 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 7 2024, 2:08 PM
Closed by commit rCOMM9630b275ef41: [native] rename MessageResultsScreen to PinnedMessagesScreen (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9630b275ef41: [native] rename MessageResultsScreen to PinnedMessagesScreen.
Harbormaster completed remote builds in B26636: Diff 36808.Feb 7 2024, 2:18 PM

Revision Contents
Changeset List

Diff 36810

View Options

native/chat/chat.react.js

Loading...
View Options

native/chat/message-header.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/chat/message-result.react.js

Loading...
View Options

native/chat/message-results-screen.react.js

Loading...
View Options

native/chat/message.react.js

Loading...
View Options

native/chat/pinned-messages-screen.react.js

Loading...
View Options

native/chat/robotext-message.react.js

Loading...
View Options

native/chat/text-message.react.js

Loading...
View Options

native/navigation/nav-selectors.js

Loading...
View Options

native/navigation/route-names.js

Loading...