This implements a function in search-utils that utilizes the identity search context provider to return search results.
dispatchActionPromises and types will be added later in diff stack
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/search-utils.js | ||
|---|---|---|
| 382–384 ↗ | (On Diff #36881) | Nit – I'd move the typehint |
| lib/shared/search-utils.js | ||
|---|---|---|
| 382–384 ↗ | (On Diff #36881) | Ended up rewriting this line with GlobalUserInfo instead of User in https://phab.comm.dev/D11060. Made sure to type annotate with angle brackets in that diff. |
Comment Actions
When you receive feedback once, please make sure to internalize the feedback and carry it forward, so that your diff reviewers never have to repeat feedback
| lib/shared/search-utils.js | ||
|---|---|---|
| 382 | Same comment here... please move the typehint | |
| lib/shared/search-utils.js | ||
|---|---|---|
| 382 | Oh, I see what's going on... you're replacing this line in a later diff, so you're skipping responding to the feedback here. In the future, I'd suggest responding to the feedback, even if it gets removed in a later diff. It saves your diff reviewer from dealing with confusion. If rebasing is a headache right now, that is probably a skill that will get improved over time... eventually, it should be really easy for you to directly address feedback, and not something that you avoid. Okay to skip it this time I guess | |
| lib/shared/search-utils.js | ||
|---|---|---|
| 382 | Got it. Wasn't sure of best practice at the time but will now immediately respond to feedback going forward. | |