Paths

Table of Contentst

Differential D11004

[dev env] add toolchain file
ClosedPublic
Actions

Authored by varun on Feb 8 2024, 12:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 28, 7:50 AM

	Unknown Object (File)
	Fri, Jun 28, 1:43 AM

	Unknown Object (File)
	Tue, Jun 25, 3:47 PM

	Unknown Object (File)
	Mon, Jun 24, 12:20 AM

	Unknown Object (File)
	Mon, Jun 24, 12:17 AM

	Unknown Object (File)
	Thu, Jun 20, 1:16 AM

	Unknown Object (File)
	Thu, Jun 13, 8:13 AM

	Unknown Object (File)
	Tue, Jun 11, 10:07 AM

View All 22 Files

Subscribers

Details

Reviewers

michal
bartek
ashoat

Commits

rCOMMdd9ebd7516fb: [dev env] add toolchain file

Summary

this file ensures all devs are using the same rustup toolchain. docs on toolchain file here: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Test Plan

confirmed that the specified rustup toolchain (1.75) overrode my previously installed toolchain inside the repo.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 8 2024, 12:44 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 8 2024, 12:44 PM

varun added inline comments.Feb 8 2024, 12:47 PM

rust-toolchain.toml
1–3 ↗	(On Diff #36887)	not handling adding other targets here because we add them in `native/android/app/build.gradle` and `scripts/ensure_rustup_setup.sh`
2 ↗	(On Diff #36887)	The channel setting specifies which toolchain to use. 1.75 is the same version we use in our services Dockerfiles
3 ↗	(On Diff #36887)	default is the minimal install plus rust-docs, rustfmt, and clippy

Harbormaster completed remote builds in B26677: Diff 36887.Feb 8 2024, 1:01 PM

varun requested review of this revision.Feb 8 2024, 1:01 PM

This looks great, but I'd like one of the people that actually knows Rust to take a look too

Nice!

This revision is now accepted and ready to land.Feb 9 2024, 2:26 AM

bartek accepted this revision.Feb 9 2024, 2:27 AM

Closed by commit rCOMMdd9ebd7516fb: [dev env] add toolchain file (authored by varun). · Explain WhyFeb 9 2024, 8:13 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMdd9ebd7516fb: [dev env] add toolchain file.

Revision Contents
Changeset List

Path

Size

rust-toolchain.toml

3 lines

Diff 36935

rust-toolchain.toml

Loading...