Paths

Table of Contentst

Differential D11071

Implement JSI to handle unread count from JS
ClosedPublic
Actions

Authored by marcin on Feb 14 2024, 4:25 AM.

Tags

None

Referenced Files

	F3384140: D11071.diff
	Thu, Nov 28, 7:35 PM

	Unknown Object (File)
	Sat, Nov 23, 8:48 AM

	Unknown Object (File)
	Sat, Nov 23, 5:51 AM

	Unknown Object (File)
	Fri, Nov 22, 9:46 PM

	Unknown Object (File)
	Fri, Nov 22, 4:42 AM

	Unknown Object (File)
	Fri, Nov 22, 12:29 AM

	Unknown Object (File)
	Thu, Nov 21, 5:28 AM

	Unknown Object (File)
	Wed, Nov 6, 4:43 PM

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMMf55923678396: Implement JSI to handle unread count from JS

Summary

This differential implements two JSI calls that can update unread counts for keyservers in MMKV and remove keyservers from MMKV.

Test Plan

Apply this patch to the code: https://gist.github.com/marcinwasowicz/72f1a3ca842f9ad5e92c59dec67b7eda. This patch adds changes that use those two JSI in a "dirty" way in JS and that query MMKV for keyserver unread counts from NSE.
Build the app and keep it in foreground.
Open web app on the same client and keep marking threads as read and unread. Ensure that logs in Android studio/MacOS console app contain correct values for unread counts.
Background the app and repeat step 3. Ensure that logs in Android studio/MacOS console app contain the last value logged in step 4. This is expected - JS doesn't update MMKV in the background.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Feb 14 2024, 4:25 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 14 2024, 4:25 AM

marcin edited the test plan for this revision. (Show Details)Feb 14 2024, 4:30 AM

Harbormaster completed remote builds in B26822: Diff 37065.Feb 14 2024, 4:40 AM

marcin requested review of this revision.Feb 14 2024, 4:40 AM

tomek accepted this revision.Feb 14 2024, 9:04 AM

tomek added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
867 ↗	(On Diff #37065)	How about `keyserverUnreadCountKey`?

This revision is now accepted and ready to land.Feb 14 2024, 9:04 AM

marcin added a child revision: D11090: Update unread count storage from JS and NSE.Feb 15 2024, 5:28 AM

marcin added a parent revision: D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.

marcin mentioned this in D11045: Introduce MMKV to iOS app and NSE.Mar 1 2024, 7:25 AM

Rebase to restructure stack

marcin added a child revision: D11235: Add keyserverID to Android and iOS notification payload..Mar 4 2024, 9:44 AM

marcin removed a child revision: D11090: Update unread count storage from JS and NSE.

Harbormaster failed remote builds in B27306: Diff 37788!Mar 4 2024, 10:02 AM

Add function to get unread counts for a set of keyservers

Harbormaster failed remote builds in B27359: Diff 37882!Mar 6 2024, 5:40 AM

Fix compilation error - forgot to add std::move when resolving jsi::Array.

Harbormaster completed remote builds in B27362: Diff 37885.Mar 6 2024, 6:07 AM

Rebase before landing

Harbormaster completed remote builds in B27510: Diff 38067.Mar 14 2024, 7:35 AM

Closed by commit rCOMMf55923678396: Implement JSI to handle unread count from JS (authored by marcin). · Explain WhyMar 14 2024, 9:23 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMf55923678396: Implement JSI to handle unread count from JS.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

10 lines

CommCoreModule.cpp

129 lines

_generated/

commJSI-generated.cpp

schema/

CommCoreModuleSchema.js

9 lines

Diff 37885

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/schema/CommCoreModuleSchema.js

Loading...