[keyserver][lib][native] Rename userId -> userID
ClosedPublic
Actions

Authored by inka on Feb 21 2024, 7:28 AM.

Details

Reviewers

varun
tomek

Commits

rCOMM965e8c265133: [keyserver][lib][native] Rename userId -> userID

Summary

This is related to my comments under ENG-6883
metadataEmitter was emitting authMetadata with userID, not userId, so getAuthMetadata would throw errors
Had to change UserLoginResponse to fix this.

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Feb 21 2024, 7:28 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 21 2024, 7:28 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2024, 7:30 AM

Harbormaster failed remote builds in B27038: Diff 37405!

Undo renaming in IdentityInfo

inka edited the summary of this revision. (Show Details)Feb 21 2024, 7:45 AM

Harbormaster completed remote builds in B27040: Diff 37407.Feb 21 2024, 8:00 AM

inka requested review of this revision.Feb 21 2024, 8:00 AM

inka planned changes to this revision.Feb 21 2024, 9:09 AM

Have rust bindings use IdentityInfo, because napi-rs converts user_id to userId
We only need to use userID in places where we get data from CommServicesAuthMetadataEmitter