Page MenuHomePhabricator

[keyserver][lib][native] Rename userId -> userID
ClosedPublic

Authored by inka on Feb 21 2024, 7:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 5:42 PM
Unknown Object (File)
Fri, Nov 29, 3:40 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 12:46 AM
Unknown Object (File)
Tue, Nov 12, 10:22 PM
Subscribers

Details

Summary

This is related to my comments under ENG-6883
metadataEmitter was emitting authMetadata with userID, not userId, so getAuthMetadata would throw errors
Had to change UserLoginResponse to fix this.

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
inka/testing_multikeyservers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2024, 7:30 AM
Harbormaster failed remote builds in B27038: Diff 37405!

Undo renaming in IdentityInfo

inka requested review of this revision.Feb 21 2024, 8:00 AM
inka planned changes to this revision.Feb 21 2024, 9:09 AM
inka edited the summary of this revision. (Show Details)

Have rust bindings use IdentityInfo, because napi-rs converts user_id to userId
We only need to use userID in places where we get data from CommServicesAuthMetadataEmitter

This revision is now accepted and ready to land.Feb 21 2024, 9:42 AM