This returns null when the auth metadata returned is incomplete (contains null values).
Context: https://linear.app/comm/issue/ENG-7083/getting-auth-metadata-is-incomplete-error-when-testing-on-web
Details
Details
no longer receive uncaught promise error on web
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- identity-search-client
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Can you clarify what effects this will have downstream before landing?
Does user prefix search on identity work without auth metadata? How about exact match user search?
Comment Actions
Downstream the client will no longer attempt to initialize a websocket connection in the identity-search-context. The identitySearchSocketConnected variable in useSearchUsers will remain false and so the function will fallback to keyserver search.
Identity-based prefix search will not work but keyserver prefix search will work. We don't currently use identity-search for exact search either, so that won't be a problem.
| lib/utils/identity-search-utils.js | ||
|---|---|---|
| 27 | can we add a comment explaining why we're returning null here for the time being? | |