Paths

Table of Contentst

Differential D11238

[lib] Set CSAT on identity login / register
ClosedPublic
Actions

Authored by inka on Mar 4 2024, 9:06 AM.

Tags

None

Referenced Files

	F1741313: D11238.id37913.diff
	Sun, May 12, 11:31 PM

	F1741312: D11238.id37785.diff
	Sun, May 12, 11:31 PM

	F1741311: D11238.id37881.diff
	Sun, May 12, 11:31 PM

	F1741291: D11238.diff
	Sun, May 12, 11:31 PM

	F1741252: D11238.id.diff
	Sun, May 12, 11:09 PM

	Unknown Object (File)
	Sat, May 11, 8:14 PM

	Unknown Object (File)
	Thu, May 9, 6:31 PM

	Unknown Object (File)
	Apr 7 2024, 2:26 AM

View All 25 Files

Subscribers

Details

Reviewers

tomek
michal
varun

Commits

rCOMM220e66c5898b: [lib] Set CSAT on identity login / register

Summary

issue: ENG-6882
We decided to set the CSAT on identity login / register actions, but we only want to do that on web, since on native we set it via the emitter

Test Plan

Tested that after patching D11141 (and undoing changes in lib/reducers/services-access-token-reducer.js) it is still posible to login with identity on web - the token is correctly set

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Mar 4 2024, 9:06 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 4 2024, 9:06 AM

Harbormaster completed remote builds in B27303: Diff 37785.Mar 4 2024, 9:33 AM

inka requested review of this revision.Mar 4 2024, 9:33 AM

inka added inline comments.Mar 5 2024, 1:08 AM

web/redux/redux-setup.js
336–346 ↗	(On Diff #37785)	We do the same thing for `navInfo` - it is being reducer by the `baseReducer` from lib, but then additional changes that are web specific are applied here

tomek accepted this revision.Mar 5 2024, 6:36 AM

tomek added inline comments.

web/redux/services-access-token-reducer.js
10–21 ↗	(On Diff #37785)	In most of the reducers, we're using an export list

This revision is now accepted and ready to land.Mar 5 2024, 6:36 AM

Use an export list

Harbormaster completed remote builds in B27358: Diff 37881.Mar 6 2024, 5:29 AM

Closed by commit rCOMM220e66c5898b: [lib] Set CSAT on identity login / register (authored by inka). · Explain WhyMar 7 2024, 12:43 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM220e66c5898b: [lib] Set CSAT on identity login / register.

inka mentioned this in D11374: [lib] Avoid clearing CSAT on identityRegisterActionTypes.success.Mar 25 2024, 3:18 AM

inka mentioned this in D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.Mar 29 2024, 4:29 AM

Revision Contents
Changeset List

Path

Size

web/

redux/

5 lines

services-access-token-reducer.js

20 lines

Diff 37913

web/redux/redux-setup.js

Loading...

web/redux/services-access-token-reducer.js

Loading...