Page MenuHomePhabricator
Differential D11316

[native] fix long keyserver names ui bug
ClosedPublic
Actions

Authored by ginsu on Mar 13 2024, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 10:38 AM
Unknown Object (File)
Thu, Apr 25, 7:23 AM
Unknown Object (File)
Thu, Apr 25, 7:23 AM
Unknown Object (File)
Thu, Apr 25, 7:23 AM
Unknown Object (File)
Thu, Apr 25, 7:23 AM
Unknown Object (File)
Thu, Apr 25, 7:20 AM
Unknown Object (File)
Mar 30 2024, 6:12 AM
Unknown Object (File)
Mar 25 2024, 2:56 PM
View All 20 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM9af69c74ee2b: [native] fix long keyserver names ui bug
Summary

This diff fixes the following UI bugs with long keyserver names:

Screenshot 2024-03-13 at 2.34.24 PM.png (1×1 px, 795 KB)

Screenshot 2024-03-13 at 2.20.53 PM.png (1×1 px, 723 KB)

Linear task: https://linear.app/comm/issue/ENG-7177/long-names-in-keyserver-selection-go-out-of-screen

Test Plan

Please see the screenshots below

Screenshot 2024-03-13 at 2.45.55 PM.png (1×946 px, 617 KB)

Screenshot 2024-03-13 at 2.33.28 PM.png (1×946 px, 542 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mar 13 2024, 11:48 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 13 2024, 11:48 AM
ginsu edited the summary of this revision. (Show Details)Mar 13 2024, 11:51 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1335305: Screenshot 2024-03-13 at 2.33.28 PM.png. (Show Details)
ginsu attached a referenced file: F1335306: Screenshot 2024-03-13 at 2.45.55 PM.png. (Show Details)
ginsu attached a referenced file: F1335292: Screenshot 2024-03-13 at 2.20.53 PM.png. (Show Details)
ginsu attached a referenced file: F1335293: Screenshot 2024-03-13 at 2.34.24 PM.png. (Show Details)
Harbormaster completed remote builds in B27486: Diff 38043.Mar 13 2024, 1:18 PM
ginsu requested review of this revision.Mar 13 2024, 1:18 PM
inka accepted this revision.Mar 14 2024, 2:18 AM
This revision is now accepted and ready to land.Mar 14 2024, 2:18 AM
ginsu updated this revision to Diff 38079.Mar 14 2024, 10:05 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 14 2024, 10:07 AM
Closed by commit rCOMM9af69c74ee2b: [native] fix long keyserver names ui bug (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9af69c74ee2b: [native] fix long keyserver names ui bug.
Harbormaster completed remote builds in B27515: Diff 38079.Mar 14 2024, 10:21 AM

Revision Contents
Changeset List

Diff 38080

View Options

native/profile/keyserver-selection-bottom-sheet.react.js

Loading...
View Options

native/profile/keyserver-selection-list-item.react.js

Loading...