Page MenuHomePhabricator
Differential D11389

[lib][native] Introduce NeynarClientProvider
ClosedPublic
Actions

Authored by ashoat on Mar 26 2024, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2025, 8:30 PM
Unknown Object (File)
Feb 18 2025, 8:30 PM
Unknown Object (File)
Feb 18 2025, 8:30 PM
Unknown Object (File)
Feb 18 2025, 7:22 PM
Unknown Object (File)
Feb 7 2025, 2:17 AM
Unknown Object (File)
Jan 19 2025, 6:10 AM
Unknown Object (File)
Jan 19 2025, 5:19 AM
Unknown Object (File)
Jan 13 2025, 6:27 PM
View All 67 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM367d98f58f01: [lib][native] Introduce NeynarClientProvider
Summary

This lets us share a single Neynar client across the whole component tree.

Depends on D11388

Test Plan

Tested this using my own FID by hooking it into FarcasterDataHandler in a later commit

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
components/
44 lines
native/
76 lines

Diff 38360

View Options

lib/components/neynar-client-provider.react.js

Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Lines if (oldLastUpdate < viewer.sessionLastUpdated) {
// or the user restored the client app from a backup. Either way, we should // or the user restored the client app from a backup. Either way, we should
// invalidate the existing session, since the server has assumed that the // invalidate the existing session, since the server has assumed that the
// checkpoint is further along than it is on the client, and might not still // checkpoint is further along than it is on the client, and might not still
// have all of the updates necessary to do an incremental update // have all of the updates necessary to do an incremental update
await setNewSession(viewer, calendarQuery, oldLastUpdate); await setNewSession(viewer, calendarQuery, oldLastUpdate);
return { sessionContinued: false }; return { sessionContinued: false };
} }
if (oldLastUpdate === 0 && viewer.sessionLastUpdated === 0) {
// If both oldLastUpdate and viewer.sessionLastUpdated are 0, that indicates
// either a fresh registration, or a fresh login following a policy update
// that requires acknowledgment. In the latter case, we don't want to leave
// oldLastUpdate as 0, as it might result in a lot of old updates being
// downloaded. So we make sure to use Date.now() for the new session, and
// return { sessionContinued: false } to make sure the client gets a
// stateSyncPayloadTypes.FULL.
await setNewSession(viewer, calendarQuery, Date.now());
return { sessionContinued: false };
}
let comparisonResult = null; let comparisonResult = null;
try { try {
comparisonResult = compareNewCalendarQuery(viewer, calendarQuery); comparisonResult = compareNewCalendarQuery(viewer, calendarQuery);
} catch (e) { } catch (e) {
if (e.message !== 'unknown_error') { if (e.message !== 'unknown_error') {
throw e; throw e;
} }
} }
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines
View Options

native/root.react.js

Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Lines if (oldLastUpdate < viewer.sessionLastUpdated) {
// or the user restored the client app from a backup. Either way, we should // or the user restored the client app from a backup. Either way, we should
// invalidate the existing session, since the server has assumed that the // invalidate the existing session, since the server has assumed that the
// checkpoint is further along than it is on the client, and might not still // checkpoint is further along than it is on the client, and might not still
// have all of the updates necessary to do an incremental update // have all of the updates necessary to do an incremental update
await setNewSession(viewer, calendarQuery, oldLastUpdate); await setNewSession(viewer, calendarQuery, oldLastUpdate);
return { sessionContinued: false }; return { sessionContinued: false };
} }
if (oldLastUpdate === 0 && viewer.sessionLastUpdated === 0) {
// If both oldLastUpdate and viewer.sessionLastUpdated are 0, that indicates
// either a fresh registration, or a fresh login following a policy update
// that requires acknowledgment. In the latter case, we don't want to leave
// oldLastUpdate as 0, as it might result in a lot of old updates being
// downloaded. So we make sure to use Date.now() for the new session, and
// return { sessionContinued: false } to make sure the client gets a
// stateSyncPayloadTypes.FULL.
await setNewSession(viewer, calendarQuery, Date.now());
return { sessionContinued: false };
}
let comparisonResult = null; let comparisonResult = null;
try { try {
comparisonResult = compareNewCalendarQuery(viewer, calendarQuery); comparisonResult = compareNewCalendarQuery(viewer, calendarQuery);
} catch (e) { } catch (e) {
if (e.message !== 'unknown_error') { if (e.message !== 'unknown_error') {
throw e; throw e;
} }
} }
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines